wcslib: refactor and fix noBrokenSymlinks #380492
Open
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bjornfor
reviewed
Feb 9, 2025
Comment on lines
+26
to
+31
| # DOCDIR is set to the path $out/share/doc/wcslib, and DOCLINK points | ||
| # to the same location. | ||
| # `$(LN_S) $(notdir $(DOCDIR)) $(DOCLINK)` effectively running: | ||
| # `ln -s wcslib $out/share/doc/wcslib` | ||
| # This produces a broken link because the target location already exists | ||
| dontCheckForBrokenSymlinks = true; |
There was a problem hiding this comment.
With this explanation, it seems like what you had previously is better: I understand why removing the broken symlink is the right thing to do, as that symlink was never intended to be created by the (broken) Makefile that way.
We should also create an issue upstream about it?
There was a problem hiding this comment.
I think if DOCLINK is given a reasonable path it should work. Maybe dontCheckForBrokenSymlinks would be good too. I'm not interested in upstream feedback.
bjornfor
approved these changes
Feb 9, 2025
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #380487
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.