Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove "v" prefix in version #380998

Merged
merged 17 commits into from
Feb 12, 2025
Merged

treewide: remove "v" prefix in version #380998

merged 17 commits into from
Feb 12, 2025

Conversation

HeitorAugustoLN
Copy link
Member

@HeitorAugustoLN HeitorAugustoLN commented Feb 10, 2025 •
edited
Loading

Remove v prefix from version from all packages that have it to comply with:

nixpkgs/pkgs/README.md

Lines 383 to 385 in 38e15cc

These are the guidelines the `version` attribute of a package:
- It _must_ start with a digit. This is required for backwards-compatibility with [how `nix-env` parses derivation names](https://nix.dev/manual/nix/latest/command-ref/nix-env#selectors).

Might do a follow up for migrating unstable to 0-unstable

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 10, 2025
@nix-owners nix-owners bot requested a review from jtojnar February 10, 2025 21:33
@HeitorAugustoLN
docker-init: remove "v" prefix from version
b8c6de6 
The version string must start with a digit per nixpkgs versioning guidelines.
@HeitorAugustoLN
influxdb2: remove "v" prefix from version in libflux
fc024b2 
The version string must start with a digit per nixpkgs versioning guidelines.
@HeitorAugustoLN
lora: remove "v" prefix from version
c70b85d 
The version string must start with a digit per nixpkgs versioning guidelines
@HeitorAugustoLN
lora: use tag in fetchFromGitHub
41d706f
@HeitorAugustoLN
lora: use finalAttrs instead of rec
abc4b21
@HeitorAugustoLN
lora: remove with lib from meta
4346407
@HeitorAugustoLN
phpExtensions.uuid: remove "v" prefix in version
6600f70 
The version string must start with a digit per nixpkgs versioning guidelines.
@HeitorAugustoLN
msgraph-cli: remove "v" prefix in version
ce3377b 
The version string must start with a digit per nixpkgs versioning guidelines.
@HeitorAugustoLN
pythonPackages.falconpy: remove "v" prefix from version
f4b56e7 
    The version string must start with a digit per nixpkgs versioning guideline.
@HeitorAugustoLN
hullcaster: remove "v" prefix from version
9b40045 
The version string must start with a digit per nixpkgs versioning guideline.
@HeitorAugustoLN
git-together: remove "v" prefix from version
9cb6a2b 
The version string must start with a digit per nixpkgs versioning guideline.
@HeitorAugustoLN
ncps: remove "v" prefix from version
a84b1a0 
The version string must start with a digit per nixpkgs versioning guideline.
@HeitorAugustoLN
gede: remove "v" prefix from version
c24c2a6 
The version string must start with a digit per nixpkgs versioning guideline.
@HeitorAugustoLN
vmctl: remove "v" prefix from version
6e37a9a 
The version string must start with a digit per nixpkgs versioning guideline.
@HeitorAugustoLN
criterion: remove "v" prefix from version of test derivation
c4ea434 
The version string must start with a digit per nixpkgs versioning guideline.
@HeitorAugustoLN
gnomeExtensions.pano: remove "v" prefix in version
9a9523f 
The version string must start with a digit per nixpkgs versioning guideline.
@HeitorAugustoLN
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380998

x86_64-linux

✅ 19 packages built:
  • docker-init
  • gede
  • git-together
  • gnomeExtensions.pano
  • hullcaster
  • influxdb2
  • influxdb2-server
  • lora
  • msgraph-cli
  • ncps
  • php81Extensions.uuid
  • php82Extensions.uuid
  • php83Extensions.uuid
  • php84Extensions.uuid
  • python312Packages.falconpy
  • python312Packages.falconpy.dist
  • python313Packages.falconpy
  • python313Packages.falconpy.dist
  • vmctl

@HeitorAugustoLN
influxdb: remove "v" prefix in version in libflux
df198fe 
The version string must start with a digit per nixpkgs versioning guidelines.
@HeitorAugustoLN
Copy link
Member Author

Just found that there are multiple other packages that have it, but most of them are auto-generated such as lisp-modules imported and coq-modules contribs. Probably better to do these ones in a separate PR, if possible to change

@HeitorAugustoLN
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380998

x86_64-linux

✅ 20 packages built:
  • docker-init
  • gede
  • git-together
  • gnomeExtensions.pano
  • hullcaster
  • influxdb
  • influxdb2
  • influxdb2-server
  • lora
  • msgraph-cli
  • ncps
  • php81Extensions.uuid
  • php82Extensions.uuid
  • php83Extensions.uuid
  • php84Extensions.uuid
  • python312Packages.falconpy
  • python312Packages.falconpy.dist
  • python313Packages.falconpy
  • python313Packages.falconpy.dist
  • vmctl

donovanglover
donovanglover approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all commits LGTM

@HeitorAugustoLN HeitorAugustoLN added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 12, 2025
Aleksanaa
Aleksanaa approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked again

@Aleksanaa Aleksanaa merged commit 3fc2d82 into NixOS:master Feb 12, 2025
24 checks passed
@HeitorAugustoLN HeitorAugustoLN deleted the remove-v-in-version branch February 12, 2025 09:01
This was referenced Feb 13, 2025
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@donovanglover donovanglover donovanglover approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

@aanderse aanderse Awaiting requested review from aanderse

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: php 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HeitorAugustoLN @drupol @donovanglover @Aleksanaa