-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitwarden-desktop: 2025.1.1 -> 2025.2.0 #381008
bitwarden-desktop: 2025.1.1 -> 2025.2.0 #381008
Conversation
51a2151
to
ffc1caf
Compare
Not nicer, but easier: https://github.com/NixOS/nixpkgs/pull/376765/files#diff-cea960104b987ac2db5ca35c8d5b44c48c9dbe142f77b8b3526d01c64b1f896dR56 |
Edit: I've just tested it, it works! 🎉 |
ffc1caf
to
b25b3c0
Compare
Oo, good suggestion. I like this better than the double-versioned esbuild. Replaced it with the easier solution. |
b25b3c0
to
c8dceaa
Compare
as it's not merged yet, maybe even update to 2025.2.0? Or is there a reason to separate into another PR? |
c8dceaa
to
3f9d0e2
Compare
I've updated the package to 2025.2.0 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally, works as expected
See releases 2025.1.2, 2025.1.3 and 2025.1.4:
https://github.com/bitwarden/clients/releases?q=desktop-&expanded=true
Basically bug fixes and dependency updates.
Amongst the dependency updates are vite and esbuild. Both vite and bitwarden-desktop depend on different versions of esbuild. esbuild tries to download its binaries, but fails. Alternatively
ESBUILD_BINARY_PATH
can be used to skip the download. Setting this to one version of esbuild will fail the vite esbuild, setting this to another will fail the bitwarden-desktop esbuild. There need to be 2 versions of esbuild being used during thenpm rebuild
.I've split the
npm rebuild
step into two. One rebuilds the dependencies vite and electron and thus skipping a rebuild ofbitwarden-desktop
. This is done by specifying the dependencies to rebuild explicitly innpmRebuildFlags
. InpreBuild
,npm rebuild .
is used forbitwarden-desktop
only. This wayESBUILD_BINARY_PATH
can be specified separately with different versions.I also needed to update the biometrics patching, as the biometrics file has been renamed (
biometric.unix.main.ts
->os-biometrics-linux.service.ts
).I'm still hoping this can be resolved in a nicer way, but I haven't figured this out yet.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.