Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofono: 2.3 -> 2.14, fix some CVEs #381011

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

OPNA2608
Copy link
Contributor

2.3 is more than>1y old, r-ryantm failed due to a Python script being required to build.

There were abunch of CVEs released on this in August. 2.14 fixes afew of them, and we can fetch some patches to resolve afew more. According to Debian, we're then left with CVE-2024-7537 and CVE-2024-7538 still being exploitable. Not great, but bumping the state of this up by >1y should still be an improvement over the current situation.

Should prolly be backported to stable?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 10, 2025
@dotlambda dotlambda added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Feb 10, 2025
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, seems to work fine.

Should prolly be backported to stable?

Changelog shows no BC so I'm going to say yes.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381011


x86_64-linux

✅ 13 packages built:
  • lomiri.lomiri
  • lomiri.lomiri-indicator-network
  • lomiri.lomiri-indicator-network.dev
  • lomiri.lomiri-indicator-network.doc
  • lomiri.lomiri-push-qml
  • lomiri.lomiri-session
  • lomiri.lomiri-system-settings
  • lomiri.lomiri-system-settings-unwrapped
  • lomiri.lomiri-system-settings-unwrapped.dev
  • lomiri.teleports
  • modem-manager-gui
  • ofono
  • ofono.dev

@LeSuisse LeSuisse merged commit 0d6cd57 into NixOS:master Feb 12, 2025
28 checks passed
@LeSuisse LeSuisse added the backport release-24.11 Backport PR automatically label Feb 12, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 12, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 12, 2025

Git push to origin failed for release-24.11 with exitcode 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants