Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare-warp: include desktop-file-util to allow browser to open #381023

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

marcusramberg
Copy link
Contributor

Closes #375347

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@marcusramberg marcusramberg added 0.kind: bug Something is broken backport release-24.11 Backport PR automatically labels Feb 10, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 10, 2025
@nix-owners nix-owners bot requested a review from devpikachu February 10, 2025 23:46
Copy link
Member

@kachick kachick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381023


x86_64-linux

✅ 1 package built:
  • cloudflare-warp

Their package for ubuntu looks like requiring the desktop-file-utils 👍

#358952 (comment)

The following additional packages will be installed:
  desktop-file-utils gnupg2 libnss3-tools
Suggested packages:
  traceroute

@marcusramberg marcusramberg merged commit 20dbbf1 into NixOS:master Feb 14, 2025
29 checks passed
@marcusramberg marcusramberg deleted the marcus/warp_open_url branch February 14, 2025 15:48
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 14, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 backport release-24.11 Backport PR automatically
Projects
None yet
2 participants