dbeaver-bin: fix build on aarch64-linux #381766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed another small issue on aarch64-linux |
gepbird
changed the title
|
|
yzx9
reviewed
Feb 14, 2025
gepbird
force-pushed
the
dbeaver-remove-unsupported-arch
branch
from
c4b2bfa to
d526500
Compare
gepbird
force-pushed
the
dbeaver-remove-unsupported-arch
branch
from
d526500 to
e1584ee
Compare
|
yzx9
approved these changes
Feb 14, 2025
mkg20001
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://hydra.nixos.org/build/288415437
Previously I ignored
libc.so.8(wanted on x86_64-linux) as it doesn't exist on linux and thought it was an upstream packaging issue, but after a bit of research I realized it's used on BSD. However dbeaver itself does not support BSD, so we can safely remove that. Similarly something wants alibc.so.7on aarch64-linux, and there are a bunch of other platforms that we don't need.directories removed
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.