chore: updated setup for a new contributor #149
Conversation
ngupta23
commented
Feb 12, 2025
•
ngupta23
commented
- updated setup instructions/files for a new contributor
ngupta23
changed the title
ngupta23
changed the title
environment.yml
Outdated
| @@ -2,6 +2,7 @@ name: utilsforecast | |||
| channels: | |||
| - conda-forge | |||
| dependencies: | |||
| - python=3.10 | |||
There was a problem hiding this comment.
It states it in the contributing.md. Without this, it creates an env by default using 3.13 when the command is run
There was a problem hiding this comment.
I am switched the instructions to use uv instead of conda so we can move closer to the current standards. Hope that is fine and will address this comment.
|
|
||
| # VSCode | ||
| *.code-workspace |
There was a problem hiding this comment.
this could actually be useful if setup correctly
| # VSCode | |
| *.code-workspace |
There was a problem hiding this comment.
Wont people have their individual preferences in this file?
There was a problem hiding this comment.
Also, why would you want to check this into GH unless you want everyone to use VSCode?
settings.ini
Outdated
| @@ -29,10 +29,10 @@ user = Nixtla | |||
| requirements = numpy packaging pandas>=1.1.1 | |||
| plotting_requirements = pandas[plot] plotly plotly-resampler | |||
| polars_requirements = polars[numpy] | |||
| dev_requirements = black datasetsforecast==0.0.8 nbdev<2.3.26 numba>=0.58.0 pyarrow scipy | |||
| dev_requirements = black datasetsforecast==0.0.8 nbdev<2.3.26 numba>=0.58.0 pyarrow scipy mypy flake8 | |||
There was a problem hiding this comment.
I've told you several times that these are sorted alphabetically. also we don't need those, we just need pre-commit
There was a problem hiding this comment.
I guess contributing.md needs to be updated to state that we are using pre-commit in this library. It is not mentioned anywhere in that file.
There was a problem hiding this comment.
updated to include
- missing libs from
environment.ymland removedenvironment.ymlsince it was redundant. - pre-commit which was missing originally
