-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send all funds on payout #153
Conversation
@mpetrun5 you can review this code, but we shouldn't merge this yet as I need to do some additional manual testing to be on the safe side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit scared of this actually haha. I guess we should:
- add confirmation that user is sure that it wan't to payout everything
- maybe when starting give big fat warning if lb payout address is same as lb tresury address or maybe don't let it start with that config?
@mpetrun5 @mpetrunic If the user wants the entire balance to be treated as reward then an additional address for lb fees must be provided. Additionally, the user is prompted to confirm this external address once more as seen in the example below ExamplePrompt example: |
Keep in mind we shouldn't have prompt on starting of load balancer (it would make it unusable to be run as service) |
Now prompt is only shown on the manual payout, not on starting LB |
Enable sending the entire balance of address as reward
PR Checklist
Changes
Issues
Closes #141