Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundler parameter to ExecutionContext #4

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

Nu-hin
Copy link
Owner

@Nu-hin Nu-hin commented Dec 16, 2024

To address issue #3 this introduces a new bundler parameter which allows STDIN-type adapters to execute remote scripts using bundle exec.

A recent change in rubygems/rubygems@076aba8 is causing the bundler to attempt to reload the script, if the used Bundler version doesn't match that, specified in the Gemfile.lock. This causes issues (#3).

A quick workaround for that is to run the remote script using `bundle exec`. In order to do this, I introduced a `bundler` parameter to the execution context (false by default).

We will have to address this properly in the future versions.
@Nu-hin Nu-hin self-assigned this Dec 16, 2024
@Nu-hin Nu-hin merged commit a601c8e into master Dec 16, 2024
19 checks passed
@Nu-hin Nu-hin deleted the bundle-parameter branch December 16, 2024 12:35
@coveralls
Copy link

coveralls commented Dec 16, 2024

Pull Request Test Coverage Report for Build 12352744400

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 99.772%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/remote_ruby/connection_adapter/local_stdin_adapter.rb 5 6 83.33%
lib/remote_ruby/connection_adapter/ssh_stdin_adapter.rb 5 6 83.33%
Totals Coverage Status
Change from base Build 12352383262: -0.2%
Covered Lines: 874
Relevant Lines: 876

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants