Cleanup ServiceProviderExtensions, remove GetFreeThreadedServiceAsync as it's not longer needed #6215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
commented
Jan 8, 2025
| } | ||
|
|
||
| return await AsyncServiceProvider.GlobalProvider.GetServiceAsync<TService, TInterface>(); | ||
| return await AsyncServiceProvider.GlobalProvider.GetServiceAsync<TService, TInterface>(throwOnFailure: false); |
There was a problem hiding this comment.
I switched from
await NuGetUIThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync();
// This is a fallback, primarily hit in tests.
return Package.GetGlobalService(typeof(TService)) as TInterface;to this.
Afaik, there's no gotchas in this switch.
cc @davkean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14007
Description
Use the extension method https://learn.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.shell.serviceextensions.getserviceasync?view=visualstudiosdk-2022 for service provider lookups. We no longer need our custom free threaded lookups.
PR Checklist
Added testsAll existing tests should catch this.Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.