-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Generator showing packaging and multiple roslyn versions #50
Open
clairernovotny
wants to merge
2
commits into
main
Choose a base branch
from
cnov-SourceGenerator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,254 @@ | ||
# EditorConfig is awesome:http://EditorConfig.org | ||
# From https://raw.githubusercontent.com/dotnet/roslyn/master/.editorconfig | ||
|
||
# top-most EditorConfig file | ||
root = true | ||
|
||
# Don't use tabs for indentation. | ||
[*] | ||
indent_style = space | ||
trim_trailing_whitespace = true | ||
# (Please don't specify an indent_size here; that has too many unintended consequences.) | ||
|
||
# Code files | ||
[*.{cs,csx,vb,vbx}] | ||
indent_size = 4 | ||
insert_final_newline = true | ||
charset = utf-8-bom | ||
|
||
# Xml project files | ||
[*.{csproj,vbproj,vcxproj,vcxproj.filters,proj,projitems,shproj}] | ||
indent_size = 2 | ||
|
||
# Xml config files | ||
[*.{props,targets,ruleset,config,nuspec,resx,vsixmanifest,vsct}] | ||
indent_size = 2 | ||
|
||
# Yml/Yaml files | ||
[*.{yaml,yml}] | ||
indent_size = 2 | ||
|
||
# Powershell files | ||
[*.ps1] | ||
indent_size = 2 | ||
|
||
# JSON files | ||
[*.json] | ||
indent_size = 2 | ||
|
||
# Shell scripts | ||
[*.sh] | ||
end_of_line = lf | ||
|
||
[*.{cmd,bat}] | ||
end_of_line = crlf | ||
|
||
# Dotnet code style settings: | ||
[*.{cs,vb}] | ||
# Sort using and Import directives with System.* appearing first | ||
dotnet_sort_system_directives_first = true | ||
# Put a blank line between System.* and Microsoft.* | ||
dotnet_separate_import_directive_groups = true | ||
|
||
# Avoid "this." and "Me." if not necessary | ||
dotnet_style_qualification_for_field = false:suggestion | ||
dotnet_style_qualification_for_property = false:suggestion | ||
dotnet_style_qualification_for_method = false:suggestion | ||
dotnet_style_qualification_for_event = false:suggestion | ||
|
||
# Use language keywords instead of framework type names for type references | ||
dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion | ||
dotnet_style_predefined_type_for_member_access = true:suggestion | ||
|
||
# Prefer read-only on fields | ||
dotnet_style_readonly_field = true:warning | ||
|
||
# Suggest more modern language features when available | ||
dotnet_style_object_initializer = true:suggestion | ||
dotnet_style_collection_initializer = true:suggestion | ||
dotnet_style_coalesce_expression = true:suggestion | ||
dotnet_style_null_propagation = true:suggestion | ||
dotnet_style_explicit_tuple_names = true:suggestion | ||
dotnet_style_prefer_inferred_tuple_names = true:suggestion | ||
dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion | ||
dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion | ||
dotnet_style_prefer_conditional_expression_over_return = false | ||
dotnet_style_prefer_conditional_expression_over_assignment = false | ||
dotnet_style_prefer_auto_properties = true:suggestion | ||
|
||
# Parentheses | ||
dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent | ||
dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent | ||
dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent | ||
dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent | ||
|
||
# Accessibility modifiers | ||
dotnet_style_require_accessibility_modifiers = omit_if_default:suggestion | ||
|
||
|
||
# Naming Rules | ||
|
||
# Interfaces start with an I and are PascalCased | ||
dotnet_naming_rule.interfaces_must_be_pascal_cased_and_prefixed_with_I.symbols = interface_symbols | ||
dotnet_naming_rule.interfaces_must_be_pascal_cased_and_prefixed_with_I.style = pascal_case_and_prefix_with_I_style | ||
dotnet_naming_rule.interfaces_must_be_pascal_cased_and_prefixed_with_I.severity = warning | ||
|
||
# External members are PascalCased | ||
dotnet_naming_rule.externally_visible_members_must_be_pascal_cased.symbols = externally_visible_symbols | ||
dotnet_naming_rule.externally_visible_members_must_be_pascal_cased.style = pascal_case_style | ||
dotnet_naming_rule.externally_visible_members_must_be_pascal_cased.severity = warning | ||
|
||
# Parameters are camelCased | ||
dotnet_naming_rule.parameters_must_be_camel_cased.symbols = parameter_symbols | ||
dotnet_naming_rule.parameters_must_be_camel_cased.style = camel_case_style | ||
dotnet_naming_rule.parameters_must_be_camel_cased.severity = warning | ||
|
||
# Constants are PascalCased | ||
dotnet_naming_rule.constants_must_be_pascal_cased.symbols = constant_symbols | ||
dotnet_naming_rule.constants_must_be_pascal_cased.style = pascal_case_style | ||
dotnet_naming_rule.constants_must_be_pascal_cased.severity = warning | ||
|
||
# Uncomment this group and comment out the next group if you prefer s_ prefixes for static fields | ||
|
||
# Private static fields are prefixed with s_ and are camelCased like s_myStatic | ||
#dotnet_naming_rule.private_static_fields_must_be_camel_cased_and_prefixed_with_s_underscore.symbols = private_static_field_symbols | ||
#dotnet_naming_rule.private_static_fields_must_be_camel_cased_and_prefixed_with_s_underscore.style = camel_case_and_prefix_with_s_underscore_style | ||
#dotnet_naming_rule.private_static_fields_must_be_camel_cased_and_prefixed_with_s_underscore.severity = warning | ||
|
||
# Static readonly fields are PascalCased | ||
dotnet_naming_rule.static_readonly_fields_should_be_pascal_case.symbols = private_static_readonly_field_symbols | ||
dotnet_naming_rule.static_readonly_fields_should_be_pascal_case.style = pascal_case_style | ||
dotnet_naming_rule.static_readonly_fields_should_be_pascal_case.severity = warning | ||
|
||
# Comment this group and uncomment out the next group if you don't want _ prefixed fields. | ||
|
||
# Private instance fields are camelCased with an _ like _myField | ||
#dotnet_naming_rule.private_instance_fields_must_be_camel_cased_and_prefixed_with_underscore.symbols = private_field_symbols | ||
#dotnet_naming_rule.private_instance_fields_must_be_camel_cased_and_prefixed_with_underscore.style = camel_case_and_prefix_with_underscore_style | ||
#dotnet_naming_rule.private_instance_fields_must_be_camel_cased_and_prefixed_with_underscore.severity = warning | ||
|
||
# Private instance fields are camelCased | ||
dotnet_naming_rule.private_instance_fields_must_be_camel_cased.symbols = private_field_symbols | ||
dotnet_naming_rule.private_instance_fields_must_be_camel_cased.style = camel_case_style | ||
dotnet_naming_rule.private_instance_fields_must_be_camel_cased.severity = warning | ||
|
||
# Symbols | ||
dotnet_naming_symbols.externally_visible_symbols.applicable_kinds = class,struct,interface,enum,property,method,field,event,delegate | ||
dotnet_naming_symbols.externally_visible_symbols.applicable_accessibilities = public,internal,friend,protected,protected_internal,protected_friend,private_protected | ||
|
||
dotnet_naming_symbols.interface_symbols.applicable_kinds = interface | ||
dotnet_naming_symbols.interface_symbols.applicable_accessibilities = * | ||
|
||
dotnet_naming_symbols.parameter_symbols.applicable_kinds = parameter | ||
dotnet_naming_symbols.parameter_symbols.applicable_accessibilities = * | ||
|
||
dotnet_naming_symbols.constant_symbols.applicable_kinds = field | ||
dotnet_naming_symbols.constant_symbols.required_modifiers = const | ||
dotnet_naming_symbols.constant_symbols.applicable_accessibilities = * | ||
|
||
dotnet_naming_symbols.private_static_field_symbols.applicable_kinds = field | ||
dotnet_naming_symbols.private_static_field_symbols.required_modifiers = static,shared | ||
dotnet_naming_symbols.private_static_field_symbols.applicable_accessibilities = private | ||
|
||
dotnet_naming_symbols.private_static_readonly_field_symbols.applicable_kinds = field | ||
dotnet_naming_symbols.private_static_readonly_field_symbols.required_modifiers = static,shared,readonly | ||
dotnet_naming_symbols.private_static_readonly_field_symbols.applicable_accessibilities = private | ||
|
||
dotnet_naming_symbols.private_field_symbols.applicable_kinds = field | ||
dotnet_naming_symbols.private_field_symbols.applicable_accessibilities = private | ||
|
||
# Styles | ||
dotnet_naming_style.camel_case_style.capitalization = camel_case | ||
|
||
dotnet_naming_style.pascal_case_style.capitalization = pascal_case | ||
|
||
dotnet_naming_style.camel_case_and_prefix_with_s_underscore_style.required_prefix = s_ | ||
dotnet_naming_style.camel_case_and_prefix_with_s_underscore_style.capitalization = camel_case | ||
|
||
dotnet_naming_style.camel_case_and_prefix_with_underscore_style.required_prefix = _ | ||
dotnet_naming_style.camel_case_and_prefix_with_underscore_style.capitalization = camel_case | ||
|
||
dotnet_naming_style.pascal_case_and_prefix_with_I_style.required_prefix = I | ||
dotnet_naming_style.pascal_case_and_prefix_with_I_style.capitalization = pascal_case | ||
|
||
|
||
# CSharp code style settings: | ||
[*.cs] | ||
# Modifier order | ||
csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion | ||
|
||
# Code block | ||
csharp_prefer_braces = false:none | ||
|
||
# Indentation preferences | ||
csharp_indent_block_contents = true | ||
csharp_indent_braces = false | ||
csharp_indent_case_contents = true | ||
csharp_indent_switch_labels = true | ||
csharp_indent_labels = flush_left | ||
|
||
# Prefer "var" everywhere | ||
csharp_style_var_for_built_in_types = true:suggestion | ||
csharp_style_var_when_type_is_apparent = true:suggestion | ||
csharp_style_var_elsewhere = true:suggestion | ||
|
||
# Code style defaults | ||
csharp_preserve_single_line_blocks = true | ||
csharp_preserve_single_line_statements = true | ||
|
||
# Prefer method-like constructs to have a block body | ||
csharp_style_expression_bodied_methods = false:none | ||
csharp_style_expression_bodied_constructors = false:none | ||
csharp_style_expression_bodied_operators = false:none | ||
|
||
# Prefer property-like constructs to have an expression-body | ||
csharp_style_expression_bodied_properties = true:none | ||
csharp_style_expression_bodied_indexers = true:none | ||
csharp_style_expression_bodied_accessors = true:none | ||
|
||
# Expression | ||
csharp_prefer_simple_default_expression = true:suggestion | ||
csharp_style_deconstructed_variable_declaration = true:suggestion | ||
csharp_style_pattern_local_over_anonymous_function = true:suggestion | ||
|
||
# Pattern matching | ||
csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion | ||
csharp_style_pattern_matching_over_as_with_null_check = true:suggestion | ||
csharp_style_inlined_variable_declaration = true:suggestion | ||
|
||
# Null checking preferences | ||
csharp_style_throw_expression = true:suggestion | ||
csharp_style_conditional_delegate_call = true:suggestion | ||
|
||
# Newline settings | ||
csharp_new_line_before_open_brace = all | ||
csharp_new_line_before_else = true | ||
csharp_new_line_before_catch = true | ||
csharp_new_line_before_finally = true | ||
csharp_new_line_before_members_in_object_initializers = true | ||
csharp_new_line_before_members_in_anonymous_types = true | ||
csharp_new_line_between_query_expression_clauses = true | ||
|
||
# Space preferences | ||
csharp_space_after_cast = false | ||
csharp_space_after_colon_in_inheritance_clause = true | ||
csharp_space_after_comma = true | ||
csharp_space_after_dot = false | ||
csharp_space_after_keywords_in_control_flow_statements = true | ||
csharp_space_after_semicolon_in_for_statement = true | ||
csharp_space_around_binary_operators = before_and_after | ||
csharp_space_around_declaration_statements = do_not_ignore | ||
csharp_space_before_colon_in_inheritance_clause = true | ||
csharp_space_before_comma = false | ||
csharp_space_before_dot = false | ||
csharp_space_before_open_square_brackets = false | ||
csharp_space_before_semicolon_in_for_statement = false | ||
csharp_space_between_empty_square_brackets = false | ||
csharp_space_between_method_call_empty_parameter_list_parentheses = false | ||
csharp_space_between_method_call_name_and_opening_parenthesis = false | ||
csharp_space_between_method_call_parameter_list_parentheses = false | ||
csharp_space_between_method_declaration_empty_parameter_list_parentheses = false | ||
csharp_space_between_method_declaration_name_and_open_parenthesis = false | ||
csharp_space_between_method_declaration_parameter_list_parentheses = false | ||
csharp_space_between_parentheses = false | ||
csharp_space_between_square_brackets = false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<Project> | ||
|
||
<PropertyGroup> | ||
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)key.snk</AssemblyOriginatorKeyFile> | ||
<LangVersion>latest</LangVersion> | ||
<SignAssembly>true</SignAssembly> | ||
<DebugType>embedded</DebugType> | ||
</PropertyGroup> | ||
|
||
</Project> |
20 changes: 20 additions & 0 deletions
20
...ceGeneratorExample/SourceGeneratorExample.Roslyn38/SourceGeneratorExample.Roslyn38.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
|
||
<PropertyGroup> | ||
<TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
<AssemblyName>SourceGeneratorExampleV1</AssemblyName> | ||
<RootNamespace>SourceGeneratorExample</RootNamespace> | ||
<IsPackable>false</IsPackable> | ||
<IsRoslynComponent>true</IsRoslynComponent> | ||
<Nullable>enable</Nullable> | ||
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.8.0" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<Compile Include="..\SourceGeneratorExample.Shared\**\*.cs" /> | ||
</ItemGroup> | ||
|
||
</Project> |
21 changes: 21 additions & 0 deletions
21
...ceGeneratorExample/SourceGeneratorExample.Roslyn40/SourceGeneratorExample.Roslyn40.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
|
||
<PropertyGroup> | ||
<TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
<AssemblyName>SourceGeneratorExampleV2</AssemblyName> | ||
<RootNamespace>SourceGeneratorExample</RootNamespace> | ||
<IsPackable>false</IsPackable> | ||
<IsRoslynComponent>true</IsRoslynComponent> | ||
<Nullable>enable</Nullable> | ||
<DefineConstants>$(DefineConstants);ROSLYN_4</DefineConstants> | ||
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.0.1" PrivateAssets="all" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<Compile Include="..\SourceGeneratorExample.Shared\**\*.cs" /> | ||
</ItemGroup> | ||
|
||
</Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was seeking examples of linking to other docs and found this.
Should "en-us" be removed, at least? Or do we just leave that and let the client redirect to the correct language?