Escape all sources when they need it (#967)

The need for escaping doesn't depend on if it's a local (file) or remote (http/s) uri It depends only on if there is a space in it or not. This can be in either, although it's more likely in a file path with "C:\Program Files" etc ArgumentEscaper will check for spaces and handle it when needed Co-authored-by: Anthony Steele <[email protected]>
NuKeeperDotNet · May 7, 2020 · 4d9caad · 4d9caad
1 parent 6ab8956
commit 4d9caad
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/NuKeeper.Abstractions/NuGet/NuGetSources.cs b/NuKeeper.Abstractions/NuGet/NuGetSources.cs
@@ -45,7 +45,7 @@ public NuGetSources(IEnumerable<PackageSource> sources)
         public string CommandLine(string prefix)
         {
             return Items
-                .Select(s => $"{prefix} {EscapePathIfLocal(s)}")
+                .Select(s => $"{prefix} {EscapeSource(s)}")
                 .JoinWithSeparator(" ");
         }
 
@@ -54,9 +54,9 @@ public override string ToString()
             return Items.Select(s => s.SourceUri.ToString()).JoinWithCommas();
         }
 
-        private static string EscapePathIfLocal(PackageSource source)
+        private static string EscapeSource(PackageSource source)
         {
-            return source.IsLocal ? ArgumentEscaper.EscapeAndConcatenate(new[] { source.Source }) : source.Source;
+            return ArgumentEscaper.EscapeAndConcatenate(new[] { source.Source });
         }
     }
 }