TA#63236 [IMP] Add precommit, flake8 and github workflow (#16)

* TA#63236 [IMP] Add precommit, flake8 and github workflow
* TA#63236 [IMP] Correct flake8 issues

.flake8

@@ -0,0 +1,12 @@
+[flake8]
+max-line-length = 88
+max-complexity = 16
+# B = bugbear
+# B9 = bugbear opinionated (incl line length)
+select = C,E,F,W,B,B9
+# E203: whitespace before ':' (black behaviour)
+# E501: flake8 line length (covered by bugbear B950)
+# W503: line break before binary operator (black behaviour)
+ignore = E203,E501,W503,F821
+per-file-ignores=
+    __init__.py:F401

.github/workflows/pre-commit.yml

@@ -0,0 +1,36 @@
+name: pre-commit
+
+on:
+  pull_request:
+    branches:
+      - "14.0*"
+  push:
+    branches:
+      - "14.0"
+
+jobs:
+  pre-commit:
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-python@v2
+        with:
+          python-version: "3.11"
+      - name: Get python version
+        run: echo "PY=$(python -VV | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
+      - uses: actions/cache@v1
+        with:
+          path: ~/.cache/pre-commit
+          key: pre-commit|${{ env.PY }}|${{ hashFiles('.pre-commit-config.yaml') }}
+      - name: Install pre-commit
+        run: pip install pre-commit
+      - name: Run pre-commit
+        run: pre-commit run --all-files --show-diff-on-failure --color=always
+      - name: Check that all files generated by pre-commit are in git
+        run: |
+          newfiles="$(git ls-files --others --exclude-from=.gitignore)"
+          if [ "$newfiles" != "" ] ; then
+              echo "Please check-in the following files:"
+              echo "$newfiles"
+              exit 1
+          fi

.pre-commit-config.yaml

@@ -0,0 +1,30 @@
+exclude: |
+  (?x)
+  # NOT INSTALLABLE ADDONS
+  # END NOT INSTALLABLE ADDONS
+  # Files and folders generated by bots, to avoid loops
+  ^setup/|/static/description/index\.html$|
+  # We don't want to mess with tool-generated files
+  .svg$|/tests/([^/]+/)?cassettes/|^.copier-answers.yml$|^.github/|
+  # Maybe reactivate this when all README files include prettier ignore tags?
+  ^README\.md$|
+  # Library files can have extraneous formatting (even minimized)
+  /static/(src/)?lib/|
+  # Repos using Sphinx to generate docs don't need prettying
+  ^docs/_templates/.*\.html$|
+  # Don't bother non-technical authors with formatting issues in docs
+  readme/.*\.(rst|md)$|
+  # Ignore build and dist directories in addons
+  /build/|/dist/|
+  # You don't usually want a bot to modify your legal texts
+  (LICENSE.*|COPYING.*)
+default_language_version:
+  python: python3
+  node: "14.13.0"
+repos:
+  - repo: https://github.com/PyCQA/flake8
+    rev: 3.8.3
+    hooks:
+      - id: flake8
+        name: flake8
+        additional_dependencies: ["flake8-bugbear==20.1.4"]

fetchmail_outlook_by_company/models/microsoft_outlook_mixin.py

@@ -52,19 +52,29 @@ def _compute_outlook_uri_by_company(self):
                 record.microsoft_outlook_uri = False
                 continue
 
-            record.microsoft_outlook_uri = url_join(self._get_microsoft_endpoint(), 'authorize?%s' % url_encode({
-                'client_id': microsoft_outlook_client_id,
-                'response_type': 'code',
-                'redirect_uri': url_join(base_url, '/microsoft_outlook/confirm'),
-                'response_mode': 'query',
-                # offline_access is needed to have the refresh_token
-                'scope': 'offline_access %s' % self._OUTLOOK_SCOPE,
-                'state': json.dumps({
-                    'model': record._name,
-                    'id': record.id,
-                    'csrf_token': record._get_outlook_csrf_token(),
-                })
-            }))
+            record.microsoft_outlook_uri = url_join(
+                self._get_microsoft_endpoint(),
+                "authorize?%s"
+                % url_encode(
+                    {
+                        "client_id": microsoft_outlook_client_id,
+                        "response_type": "code",
+                        "redirect_uri": url_join(
+                            base_url, "/microsoft_outlook/confirm"
+                        ),
+                        "response_mode": "query",
+                        # offline_access is needed to have the refresh_token
+                        "scope": "offline_access %s" % self._OUTLOOK_SCOPE,
+                        "state": json.dumps(
+                            {
+                                "model": record._name,
+                                "id": record.id,
+                                "csrf_token": record._get_outlook_csrf_token(),
+                            }
+                        ),
+                    }
+                ),
+            )
 
     @api.depends('use_microsoft_outlook_service', 'company_id')
     def _compute_outlook_uri(self):