Skip to content

Commit

Permalink
Code Review
Browse files Browse the repository at this point in the history
  • Loading branch information
majouda committed Jul 2, 2024
1 parent 15a4872 commit 7d8a18d
Show file tree
Hide file tree
Showing 8 changed files with 40 additions and 33 deletions.
57 changes: 27 additions & 30 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,33 +21,30 @@ jobs:
name: Setup Log Folder For Reports
command: sudo mkdir -p .log && sudo chmod 777 .log

# - run:
# name: Run Test
# command: docker-compose run --rm odoo run_pytest.sh
- run:
name: Run Test
command: docker-compose run --rm odoo run_pytest.sh

# - run:
# name: Codacy Coverage
# command: bash <(curl -Ls https://coverage.codacy.com/get.sh) report -l python -r .log/coverage.xml
# - store_test_results:
# path: .log
- store_test_results:
path: .log

# job that find the next tag for the current branch/repo and push the tag to github.
# it will trigger the publish of a new docker image.
# auto-tag:
# machine: true
# steps:
# - checkout
# - run:
# <<: *quay_io_login
# - run:
# name: Get nws
# command: |
# curl -L $NWS_BIN_LOCATION > ./nws
# chmod +x ./nws
# - run:
# name: Set tag
# command: |
# ./nws circleci create-tag -t odoo-base
auto-tag:
machine: true
steps:
- checkout
- run:
<<: *quay_io_login
- run:
name: Get nws
command: |
curl -L $NWS_BIN_LOCATION > ./nws
chmod +x ./nws
- run:
name: Set tag
command: |
./nws circleci create-tag -t odoo-base
workflows:
version: 2
Expand All @@ -56,10 +53,10 @@ workflows:
- tests:
context: quay.io

# - auto-tag:
# context: nws
# requires:
# - tests
# filters:
# branches:
# only: /^1\d\.0/
- auto-tag:
context: nws
requires:
- tests
filters:
branches:
only: /^1\d\.0/
2 changes: 2 additions & 0 deletions .docker_files/main/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
"category": "Other",
"summary": "Install all addons required for testing.",
"depends": [
"contacts",
"partner_autocomplete_disable"
"partner_firstname_before_lastname"
],
"installable": True,
Expand Down
2 changes: 1 addition & 1 deletion .docker_files/odoo.conf
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ log_handler = :INFO
log_level = info
logfile = None
logrotate = False
gevent-port = 8071
longpolling_port = 8071
max_cron_threads = 1
osv_memory_age_limit = 1.0
osv_memory_count_limit = False
Expand Down
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ RUN gitoo install-all --conf_file /gitoo.yml --destination "${THIRD_PARTY_ADDONS

USER odoo

COPY partner_autocomplete_disable /mnt/extra-addons/partner_autocomplete_disable
COPY partner_firstname_before_lastname /mnt/extra-addons/partner_firstname_before_lastname

COPY .docker_files/main /mnt/extra-addons/main
Expand Down
1 change: 1 addition & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
version: '3'
services:
odoo:
build:
Expand Down
6 changes: 6 additions & 0 deletions gitoo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,9 @@
branch: "16.0"
includes:
- partner_firstname

- url: https://github.com/OCA/queue
branch: "16.0"
includes:
- queue_job
- queue_job_cron
2 changes: 1 addition & 1 deletion partner_firstname_before_lastname/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# -*- coding: utf-8 -*-
# © 2022 Numigi (tm) and all its contributors (https://bit.ly/numigiens)
# © 2024 Numigi (tm) and all its contributors (https://bit.ly/numigiens)
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

def set_partner_names_order_in_res_config_settings(cr, registry):
Expand Down
2 changes: 1 addition & 1 deletion partner_firstname_before_lastname/__manifest__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# -*- coding: utf-8 -*-
# © 2022 Numigi (tm) and all its contributors (https://bit.ly/numigiens)
# © 2024 Numigi (tm) and all its contributors (https://bit.ly/numigiens)
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

{

Check warning on line 5 in partner_firstname_before_lastname/__manifest__.py

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

partner_firstname_before_lastname/__manifest__.py#L5

Statement seems to have no effect
Expand Down

0 comments on commit 7d8a18d

Please sign in to comment.