[17.0][OU-ADD] sale: Migration to 17.0

[acpMicrocom]

No description provided.

[legalsylvain]

/ocabot migration sale

Depends on :

• sales_team : [17.0][OU-ADD] sales_team: nothing to do #4685
• account_payment : [17.0][OU-ADD] account_payment: Migrate to 17.0 #4650
• utm : [17.0][OU-ADD] utm: Nothing to do #4664

[pedrobaeza]

For each line (or batch of lines) of the analysis file where there's a nothing to do, you have to indicate why is nothing to do. It seems a bit weird that there's nothing to do on the DB schema part.

[legalsylvain]

Indeed, as said by pedro, please analyse the difference between V16 and V17.

I took a quick look. For exemple, new 'locked' and removal of 'done' state should be handled.

Thanks !

[legalsylvain]

Hi @rvalyi. Thanks for the explanation. I allowed me to put all the odoo-module-diff comment in off-topic, as the current PR is about "sale" migration. Feel free to open dedicated issue if you want to talk about the akretion tool. thanks !

[legalsylvain]

Hi. Thanks for your patch !

question: why create a temporary field. I mean, you can simply add locked field, update the value (based on state = "done"), then update state = sale, where state = done). ?

convention: could change the name of the function, for a more explicit one. "def _sale_sale_order" is not very explicit. something like "def _sale_order_populate_locked_field" looks better. (or something like that.)

thanks !

[acpMicrocom]

During the execution of the tests in the pull request for the sale module migration script, the following error occurs:

ERROR: column res_partner.complete_name does not exist

This error occurs because the complete_name field of the res_partner model is not available until the base addon is installed or updated. To resolve the problem, it is necessary to make sure that the base module is installed and updated before running the tests.

[dansanti]

Hello!

I think with this query, we can merge it with website_sale_digital

openupgrade.logged_query(
    env.cr,
    """
    UPDATE product_document
    SET attached_on = 'sale_order'
    FROM ir_attachment ir
    WHERE product_document.ir_attachment_id = ir.id
      AND ir.product_downloadable = TRUE
    """
)```

[hbrunn]

the ORM does this automatically

[hbrunn]

locking should be conditional on the creating user having the sale.group_auto_done_setting group.

Better do this in post-migration anyways, then you don't need to create the column manually

[acpMicrocom]

Hi, @hbrunn,

Thank you for your comment. You can proceed with the changes in this Pull Request, as we currently don’t have any hours allocated for contributions

[hbrunn]

@acpMicrocom done in #4691

@dansanti I think this belongs into the website_sale migration, I left a comment there mentioning your input