[16.0][FIX] stock: handle improper variable declaration #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
approved these changes
Jan 14, 2025
|
Hello @pedrobaeza , I can see that the merge button is available to me.
I'm reporting this to you because I am not a maintainer, I don't think I should have access to it |
|
I don't get you. It's already merged. |
|
@pedrobaeza The thing is before you merged this, I could have too. But I'm not a maintainer. |
|
I don't think so. The dropdown you are showing is not for merging, but for updating your branch if I'm not mistaken. |
|
oh my, sorry for the trouble |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation
viewwill always be truthy, even when no view is foundWith this PR the intended behavior is restored