[18.0][MIG] stock_analytic: Migration to 18.0 #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Stock analytic XML part is now migrated Add logo for generic modules
- migration point, put all the modules to not installable
This module allows the user to generate analytic information from stock moves. - Fixed flake8 and pylint errors.
Remove sale and purchase dependency. Add test Only assign analytic account if account != valuation acc Changing field name account_analytic_id Adjust to OCA latest guidelines. Add some usahe info on README
Remove remaining encoding hints. Correct lint in test Correct flake8 in test Fix documentation and test_flake8
Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-11.0/account-analytic-11.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-stock_analytic/de/
Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/ca/
Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/hr/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/de/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/es/
(cherry picked from commit 9255622)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-17.0/account-analytic-17.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-stock_analytic/
Currently translated at 100.0% (10 of 10 strings) Translation: account-analytic-17.0/account-analytic-17.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-stock_analytic/it/
Needed to also rename method starting with double-underscrore to avoid Python method name mangling.
Currently translated at 100.0% (10 of 10 strings) Translation: account-analytic-17.0/account-analytic-17.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-stock_analytic/ca/
This commit fixes analytic_distribution not being passed from move to move line when updated after the move line is created.
|
This PR has the |
|
@pedrobaeza this PR can be merged. thanks ! |
dreispt
approved these changes
Dec 1, 2024
|
/ocabot migration stock_analytic |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Dec 1, 2024
|
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-710-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@dreispt is there anything we can do to merge this? |
gbrito
suggested changes
Jan 10, 2025
| "code": "tv", | ||
| "account_type": "liability_current", | ||
| "reconcile": True, | ||
| "company_ids": [(4, [cls.env.ref("base.main_company").id])], |
There was a problem hiding this comment.
can you update this so the test pass and it can be merge
Suggested change
| "company_ids": [(4, [cls.env.ref("base.main_company").id])], | |
| "company_ids": [Command.link(cls.env.ref("base.main_company").id)], |
| "code": "tsti", | ||
| "account_type": "expense", | ||
| "reconcile": True, | ||
| "company_ids": [(4, [cls.env.ref("base.main_company").id])], |
There was a problem hiding this comment.
can you update this so the test pass and it can be merge
Suggested change
| "company_ids": [(4, [cls.env.ref("base.main_company").id])], | |
| "company_ids": [Command.link(cls.env.ref("base.main_company").id)], |
| "code": "tout", | ||
| "account_type": "income", | ||
| "reconcile": True, | ||
| "company_ids": [(4, [cls.env.ref("base.main_company").id])], |
There was a problem hiding this comment.
can you update this so the test pass and it can be merge
Suggested change
| "company_ids": [(4, [cls.env.ref("base.main_company").id])], | |
| "company_ids": [Command.link(cls.env.ref("base.main_company").id)], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module migrated to version 18.0
cc https://github.com/APSL 163677
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko please review