[18.0][MIG] account_analytic_spread_by_tag: Migration to 18.0 #712
Conversation
Currently translated at 100.0% (16 of 16 strings) Translation: account-analytic-17.0/account-analytic-17.0-account_analytic_spread_by_tag Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-account_analytic_spread_by_tag/it/
peluko00
changed the title
|
Hi @peluko00 , Please rebase and remove test-requirements.txt as the dependency has been merged. Thanks. |
peluko00
force-pushed
the
18.0-mig-account_analytic_spread_by_tag
branch
from
ae2e449 to
d8cfa29
Compare
Done! |
| { | ||
| "name": default_name, | ||
| "date": self.date, | ||
| "account_id": aac.id, |
There was a problem hiding this comment.
This approach doesn't work correctly because it always assigns the analytic account to the project plan defined in the settings:
self.env["ir.config_parameter"].sudo().get_param("analytic.project_plan", 0) This retrieves the plan that should be in the account_id.
You need to determine whether the plan belongs in the account_id or in one of the dynamic x_plan{id}_id fields. These x_plan fields are autogenerated based on the analytic plans you have, identified by their ID.
To fix this, you can do the following:
| "account_id": aac.id, | |
| aac.root_plan_id._column_name(): aac.id, |
There was a problem hiding this comment.
Maybe @miquelalzanillas can review the changes and then open a FIX pr for this.
There was a problem hiding this comment.
Thanks for the review @BernatObrador, @miquelalzanillas what do you think about it?
There was a problem hiding this comment.
There was a problem hiding this comment.
Done, thanks! Can you review again @miquelalzanillas @BernatObrador please?
peluko00
force-pushed
the
18.0-mig-account_analytic_spread_by_tag
branch
from
d8cfa29 to
a05b7e2
Compare
peluko00
force-pushed
the
18.0-mig-account_analytic_spread_by_tag
branch
from
a05b7e2 to
67e842e
Compare
Module migrated to version 18.0
cc https://github.com/APSL 163686
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko please review
[Issue] Migration to version 18.0 #696
Depends on:
[account_analytic_tag] [18.0][MIG] account_analytic_tag: Migration to 18.0 #709