[18.0][MIG] account_credit_control: Migration to 18.0

OCA · Jan 10, 2025 · f230221 · f230221
1 parent 6dcdce0
commit f230221
Show file tree

Hide file tree

Showing 15 changed files with 56 additions and 55 deletions.
diff --git a/account_credit_control/README.rst b/account_credit_control/README.rst
@@ -128,6 +128,7 @@ Contributors
 -  `360ERP <https://www.360erp.com>`__:
 
    -  Andrea Stirpe
+   -  Kevin Khao
 
 Maintainers
 -----------

diff --git a/account_credit_control/__manifest__.py b/account_credit_control/__manifest__.py
@@ -5,7 +5,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 {
     "name": "Account Credit Control",
-    "version": "17.0.1.0.0",
+    "version": "18.0.1.0.0",
     "author": "Camptocamp,"
     "Odoo Community Association (OCA),"
     "Okia,"

diff --git a/account_credit_control/models/credit_control_line.py b/account_credit_control/models/credit_control_line.py
@@ -119,7 +119,7 @@ class CreditControlLine(models.Model):
         store=True,
     )
     level = fields.Integer(
-        related="policy_level_id.level", group_operator="max", store=True
+        related="policy_level_id.level", aggregator="max", store=True
     )
     manually_overridden = fields.Boolean()
     run_id = fields.Many2one(comodel_name="credit.control.run", string="Source")

diff --git a/account_credit_control/readme/CONTRIBUTORS.md b/account_credit_control/readme/CONTRIBUTORS.md
@@ -18,3 +18,4 @@
 - Naglis Jonaitis (Versada UAB) \<<[email protected]>\>
 - [360ERP](https://www.360erp.com):
   - Andrea Stirpe
+  - Kevin Khao
diff --git a/account_credit_control/report/account_credit_control_analysis.xml b/account_credit_control/report/account_credit_control_analysis.xml
@@ -8,15 +8,15 @@
         >credit.control.analysis.tree (in account_credit_control_analysis)</field>
         <field name="model">credit.control.analysis</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="partner_id" />
                 <field name="partner_ref" />
                 <field name="policy_id" />
                 <field name="policy_level_id" />
                 <field name="level" />
                 <field name="open_balance" widget="monetary" />
                 <field name="currency_id" invisible="1" />
-            </tree>
+            </list>
         </field>
     </record>
     <record id="credit_control_analysis_pivot_view" model="ir.ui.view">
@@ -37,7 +37,7 @@
     <record model="ir.actions.act_window" id="credit_control_analysis_act_window">
         <field name="name">Credit Control Analysis</field>
         <field name="res_model">credit.control.analysis</field>
-        <field name="view_mode">tree,pivot</field>
+        <field name="view_mode">list,pivot</field>
         <field name="domain">[]</field>
         <field name="context">{}</field>
     </record>

diff --git a/account_credit_control/static/description/index.html b/account_credit_control/static/description/index.html
@@ -468,6 +468,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <li>Naglis Jonaitis (Versada UAB) &lt;<a class="reference external" href="mailto:naglis&#64;versada.eu">naglis&#64;versada.eu</a>&gt;</li>
 <li><a class="reference external" href="https://www.360erp.com">360ERP</a>:<ul>
 <li>Andrea Stirpe</li>
+<li>Kevin Khao</li>
 </ul>
 </li>
 </ul>

diff --git a/account_credit_control/tests/test_account_move.py b/account_credit_control/tests/test_account_move.py
@@ -7,8 +7,7 @@
 
 from odoo import fields
 from odoo.exceptions import UserError
-from odoo.tests import tagged
-from odoo.tests.common import Form
+from odoo.tests import Form, tagged
 
 from odoo.addons.account.tests.common import AccountTestInvoicingCommon
 from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
@@ -17,8 +16,8 @@
 @tagged("post_install", "-at_install")
 class TestAccountInvoice(AccountTestInvoicingCommon):
     @classmethod
-    def setUpClass(cls, chart_template_ref=None):
-        super().setUpClass(chart_template_ref=chart_template_ref)
+    def setUpClass(cls):
+        super().setUpClass()
         cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))
         cls.env.user.groups_id |= cls.env.ref(
             "account_credit_control.group_account_credit_control_manager"

diff --git a/account_credit_control/tests/test_credit_control_run.py b/account_credit_control/tests/test_credit_control_run.py
@@ -9,8 +9,7 @@
 
 from odoo import fields
 from odoo.exceptions import AccessError, UserError
-from odoo.tests import tagged
-from odoo.tests.common import Form
+from odoo.tests import Form, tagged
 
 from odoo.addons.account.tests.common import AccountTestInvoicingCommon
 from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
@@ -19,8 +18,8 @@
 @tagged("post_install", "-at_install")
 class TestCreditControlRun(AccountTestInvoicingCommon):
     @classmethod
-    def setUpClass(cls, chart_template_ref=None):
-        super().setUpClass(chart_template_ref=chart_template_ref)
+    def setUpClass(cls):
+        super().setUpClass()
         cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))
         cls.env.user.groups_id |= cls.env.ref(
             "account_credit_control.group_account_credit_control_manager"
@@ -110,8 +109,8 @@ def test_generate_credit_lines(self):
         self.assertEqual(control_run.state, "done")
 
         report_regex = (
-            r'<p>Policy "<b>%s</b>" has generated <b>'
-            r"\d+ Credit Control Lines.</b><br></p>" % self.policy.name
+            rf'<p>Policy "<b>{self.policy.name}</b>" has generated <b>'
+            r"\d+ Credit Control Lines.</b><br></p>"
         )
         regex_result = re.match(report_regex, control_run.report)
         self.assertIsNotNone(regex_result)
@@ -161,8 +160,8 @@ def test_wiz_print_lines(self):
         self.assertEqual(control_run.state, "done")
 
         report_regex = (
-            r'<p>Policy "<b>%s</b>" has generated <b>'
-            r"\d+ Credit Control Lines.</b><br></p>" % self.policy.name
+            rf'<p>Policy "<b>{self.policy.name}</b>" has generated <b>'
+            r"\d+ Credit Control Lines.</b><br></p>"
         )
         regex_result = re.match(report_regex, control_run.report)
         self.assertIsNotNone(regex_result)
@@ -196,8 +195,8 @@ def test_wiz_credit_control_emailer(self):
         self.assertEqual(control_run.state, "done")
 
         report_regex = (
-            r'<p>Policy "<b>%s</b>" has generated <b>'
-            r"\d+ Credit Control Lines.</b><br></p>" % self.policy.name
+            rf'<p>Policy "<b>{self.policy.name}</b>" has generated <b>'
+            r"\d+ Credit Control Lines.</b><br></p>"
         )
         regex_result = re.match(report_regex, control_run.report)
         self.assertIsNotNone(regex_result)

diff --git a/account_credit_control/views/account_move.xml b/account_credit_control/views/account_move.xml
@@ -30,15 +30,15 @@
                     </group>
                     <separator string="Issued Lines" colspan="4" />
                     <field name="credit_control_line_ids" colspan="4" nolabel="1">
-                        <tree>
+                        <list>
                             <field name="date" />
                             <field name="level" />
                             <field name="state" />
                             <field name="channel" />
                             <field name="balance_due" />
                             <field name="policy_level_id" />
                             <field name="policy_id" />
-                        </tree>
+                        </list>
                     </field>
                 </page>
             </notebook>

diff --git a/account_credit_control/views/credit_control_communication.xml b/account_credit_control/views/credit_control_communication.xml
@@ -35,15 +35,15 @@
                         </group>
                     </group>
                     <field name="credit_control_line_ids" nolabel="1">
-                        <tree>
+                        <list>
                             <field name="date" />
                             <field name="level" />
                             <field name="state" />
                             <field name="channel" />
                             <field name="balance_due" />
                             <field name="policy_level_id" />
                             <field name="policy_id" />
-                        </tree>
+                        </list>
                     </field>
                 </sheet>
                 <div class="oe_chatter">
@@ -115,24 +115,24 @@
         </field>
     </record>
     <record id="credit_control_communication_tree_view" model="ir.ui.view">
-        <field name="name">credit.control.communication.tree</field>
+        <field name="name">credit.control.communication.list</field>
         <field name="model">credit.control.communication</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="partner_id" />
                 <field name="user_id" />
                 <field name="company_id" groups="base.group_multi_company" />
                 <field name="policy_level_id" />
                 <field name="policy_id" />
                 <field name="report_date" />
-            </tree>
+            </list>
         </field>
     </record>
     <record model="ir.actions.act_window" id="credit_control_communication_action">
         <field name="name">Credit Control Communications</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">credit.control.communication</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <!-- <field name="view_id" ref="credit_control_communication_tree_view"/> -->
         <field name="help" type="html">
             <p class="oe_view_nocontent_create">

diff --git a/account_credit_control/views/credit_control_line.xml b/account_credit_control/views/credit_control_line.xml
@@ -202,10 +202,10 @@
         </field>
     </record>
     <record id="credit_control_line_tree" model="ir.ui.view">
-        <field name="name">credit.control.line.tree</field>
+        <field name="name">credit.control.line.list</field>
         <field name="model">credit.control.line</field>
         <field name="arch" type="xml">
-            <tree
+            <list
                 editable="bottom"
                 decoration-danger="state in ('error', 'email_error')"
                 decoration-muted="state == 'ignored'"
@@ -248,7 +248,7 @@
                     icon="fa-clock-o"
                 />
                 <field name="activity_summary" />
-            </tree>
+            </list>
         </field>
     </record>
     <menuitem
@@ -264,7 +264,7 @@
         <field name="res_model">credit.control.line</field>
         <field name="domain" />
         <field name="binding_view_types">form</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="view_id" ref="credit_control_line_tree" />
         <field name="context">{'search_default_filter_draft': 1,
             'search_default_filter_to_be_sent': 1}

diff --git a/account_credit_control/views/credit_control_policy.xml b/account_credit_control/views/credit_control_policy.xml
@@ -22,14 +22,14 @@
                 <notebook colspan="4">
                     <page string="Policy levels">
                         <field name="level_ids" nolabel="1" colspan="4">
-                            <tree>
+                            <list>
                                 <field name="name" />
                                 <field name="level" />
                                 <field name="channel" />
                                 <field name="delay_days" />
                                 <field name="computation_mode" />
                                 <field name="email_template_id" />
-                            </tree>
+                            </list>
                             <form string="Policy level">
                                 <field name="name" />
                                 <notebook>
@@ -75,13 +75,13 @@
         </field>
     </record>
     <record id="credit_control_policy_tree" model="ir.ui.view">
-        <field name="name">credit.control.policy.tree</field>
+        <field name="name">credit.control.policy.list</field>
         <field name="model">credit.control.policy</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="name" />
                 <field name="do_nothing" />
-            </tree>
+            </list>
         </field>
     </record>
     <menuitem
@@ -96,7 +96,7 @@
         <field name="res_model">credit.control.policy</field>
         <field name="domain" />
         <field name="binding_view_types">form</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="view_id" ref="credit_control_policy_tree" />
     </record>
     <menuitem
@@ -131,17 +131,17 @@
         </field>
     </record>
     <record id="credit_control_policy_level_tree" model="ir.ui.view">
-        <field name="name">credit.control.policy.level.tree</field>
+        <field name="name">credit.control.policy.level.list</field>
         <field name="model">credit.control.policy.level</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="name" />
                 <field name="level" />
                 <field name="channel" />
                 <field name="delay_days" />
                 <field name="computation_mode" />
                 <field name="email_template_id" />
-            </tree>
+            </list>
         </field>
     </record>
 </odoo>
diff --git a/account_credit_control/views/credit_control_run.xml b/account_credit_control/views/credit_control_run.xml
@@ -1,18 +1,18 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
     <record id="credit_control_run_tree" model="ir.ui.view">
-        <field name="name">credit.control.run.tree</field>
+        <field name="name">credit.control.run.list</field>
         <field name="model">credit.control.run</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="date" readonly="state != 'draft'" />
                 <field
                     name="company_id"
                     groups="base.group_multi_company"
                     readonly="state != 'draft'"
                 />
                 <field name="state" />
-            </tree>
+            </list>
         </field>
     </record>
     <record id="credit_control_run_form" model="ir.ui.view">
@@ -118,7 +118,7 @@
         <field name="res_model">credit.control.run</field>
         <field name="domain" />
         <field name="binding_view_types">form</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="view_id" ref="credit_control_run_tree" />
     </record>
     <menuitem