Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] hr_holidays_public: show employee's public holidays in dashboard #157

Merged

Conversation

chienandalu
Copy link
Member

This change hooks into the core public holidays method that returns the employee's available holidays for a period of time and displays them in the Time Off dashboard calendar.

Both types of public holidays are compatible and will show up in order.

image

cc @Tecnativa TT52276

please review @pedrobaeza @victoralmau

This change hooks into the core public holidays method that returns the
employee's available holidays for a period of time and displays them in
the Time Off dashboard calendar.

Both types of public holidays are compatible and will show up in order.

TT52276
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK.

@pedrobaeza pedrobaeza added this to the 17.0 milestone Dec 19, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-157-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4680076 into OCA:17.0 Dec 19, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3fe0c74. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-fix-imp-hr_holidays_public-show-holidays branch December 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants