Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][l10n_br_base][l10n_br_nfe][l10n_br_stock] fwp 3545 #3564

Merged
merged 4 commits into from
Jan 7, 2025
Merged

[16.0][l10n_br_base][l10n_br_nfe][l10n_br_stock] fwp 3545 #3564

merged 4 commits into from
Jan 7, 2025

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Dec 29, 2024

forward port de #3545 para os módulos presentes na 16.0

O fix é bastante trivial, relativamente independente dos outros forward ports em curso e se tornou necessário por exemplo para refatorar os testes em #3563

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

CristianoMafraJunior
CristianoMafraJunior reviewed Jan 5, 2025
View reviewed changes
l10n_br_nfe/tests/nfe/v4_00/leiauteNFe/NFe35200159594315000157550010000000012062777161.xml
Copy link
Member

@CristianoMafraJunior CristianoMafraJunior Jan 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teria como corrigir a indentação desse XML, do resto esta ok pra mim

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CristianoMafraJunior neste novo commit 477bbf7 eu reformatei os arquivos XML de NFe de demo conforme sai com a nfelib.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rvalyi
Copy link
Member Author

rvalyi commented Jan 7, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3564-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d5f2528 into OCA:16.0 Jan 7, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ac7f365. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CristianoMafraJunior CristianoMafraJunior CristianoMafraJunior left review comments

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@antoniospneto antoniospneto antoniospneto approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rvalyi @OCA-git-bot @antoniospneto @marcelsavegnago @CristianoMafraJunior