Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] account_invoice_inter_company : creating a credit note should g… #738

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX] account_invoice_inter_company : creating a credit note should g… #738

wants to merge 1 commit into from

Conversation

metaminux
Copy link
Contributor

@metaminux metaminux commented Dec 11, 2024 •
edited
Loading

…enerate a supplier refund in the other company

Fix #736

@metaminux metaminux force-pushed the 16.0-fix_invoice_inter_company_full_refund branch 3 times, most recently from e482b0a to 7c04445 Compare December 11, 2024 16:47
rvalyi
rvalyi approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Just a note, in the future try to limit git messages to 50 chars, see https://github.com/OCA/odoo-community.org/blob/master/website%2FContribution%2FCONTRIBUTING.rst#commit-message

@metaminux
Copy link
Contributor Author

OK. Just a note, in the future try to limit git messages to 50 chars, see https://github.com/OCA/odoo-community.org/blob/master/website%2FContribution%2FCONTRIBUTING.rst#commit-message

Noted ! 👍🏼

@metaminux metaminux force-pushed the 16.0-fix_invoice_inter_company_full_refund branch from 7c04445 to 0515073 Compare December 13, 2024 08:53
@metaminux
Copy link
Contributor Author

@Kev-Roche @emiliesoutiras Can you review this one ?

@pedrobaeza @sebastienbeau default branch for OCA/multi-company is still 14.0, so this PR is not linked to its related isssue #736...

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@metaminux
[FIX] account_invoice_inter_company : creating a credit note should g…
41a8fcc 
…enerate a supplier refund in the other company

Fixes OCA#736
@metaminux metaminux force-pushed the 16.0-fix_invoice_inter_company_full_refund branch from 0515073 to 41a8fcc Compare December 18, 2024 15:16
@HviorForgeFlow
Copy link
Member

@rvalyi let's merge it

@metaminux
Copy link
Contributor Author

metaminux commented Jan 7, 2025 •
edited
Loading

Before merging... it seems that we need to better check if an inter company invoice doesn't already exist.

I'd like to add another test when one of the invoice/refund is canceled and posted again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiliesoutiras emiliesoutiras emiliesoutiras approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@rvalyi rvalyi rvalyi approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@metaminux @OCA-git-bot @HviorForgeFlow @rvalyi @emiliesoutiras