[MIG] partner contact nationality: Migration to 16.0

[FernandoRomera]

No description provided.

[OCA-git-bot]

Sorry @FernandoRomera you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[legalsylvain]

Hi. Thanks for porting this module.

Dont understand the design. Nationality should be a many2many, don't you think ?

[FernandoRomera]

@legalsylvain
The nationality must be a single country, as well as the VAT number.

Nationality is for individuals, and it is true that they can have more than one, but if we manage it we would have to start administering more than one VAT number and associate it to each nationality.

[legalsylvain]

It is possible to add a constrain, dont you think ?
If it is a company, limit to 1 value.

[FernandoRomera]

This is a migration pull request, I had not planned to add functionality. Once this one is approved, we can decide what is right.

[rousseldenis]

/ocabot migration partner_contact_nationality

[rousseldenis]

It is possible to add a constrain, dont you think ? If it is a company, limit to 1 value.

I don't see the use case as for a company, the nationality has to be the country used for its address (legally)

[rousseldenis]

For the multiple instances case, why not using partner_identification_number module and add a country field ?

[FernandoRomera]

Nationality is only for individuals, not for companies. The dependency of this module is clearly identified: partner_contact_personal_information_page

[DoDoViVi]

Tested on Runboat,
work as expected
LGTM
Thanks for the contribution

[MRomeera]

Ok

[rousseldenis]

@legalsylvain Could you update your review ?

[legalsylvain]

Thanks for the ping.

Well, AFAIK, this module is only for individuals contact, as it depends on partner_contact_personal_information_page module. Right ? So no problem with VAT and other stuff, as individual contact doesn't have VAT number. And as @rousseldenis for the companies, we should use the field country_id of the address part.

In that case, the field should be a M2M. Don't you think ?
Once decided, the question is when to do that changes. Now or in another PR.

[FernandoRomera]

I think it is best to leave this module for those use cases where the primary or sole nationality is identified. In case you want to be able to assign more than one nationality to the partner, you would have to use the module "partner_identification" and not this one.

[MRomeera]

Ok

[rafaelbn]

Please @yajo make here a review as original author, it could be of your interest. thank you!

[FernandoRomera]

@yajo
it looks like it's up to you, that this pr will merge. You could check it and then we can move forward. And #1422

[rousseldenis]

@FernandoRomera In fact, I see this is a duplicate of #1380

[FernandoRomera]

@rousseldenis
Sorry, we did not see the PR with the migration to 16.0.
For us you can merge the previous PR and we close this one.

[yajo]

Closing in favor of #1380. Code there is more up to date.

[yajo]

BTW people here: please go there and approve to merge.