[17.0] [MIG] product_packaging_level_salable: Migration to 17.0 #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (10 of 10 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level_salable Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level_salable/it/
Currently translated at 100.0% (10 of 10 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level_salable Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level_salable/es/
trisdoan
approved these changes
Dec 3, 2024
trisdoan
suggested changes
Dec 3, 2024
There was a problem hiding this comment.
You need to remove migration script as well
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0
bizzappdev
force-pushed
the
17.0-mig-product_packaging_level_salable-BAD
branch
from
401cb4a to
8d7471d
Compare
Removed. Thanks for noticing. |
ivantodorovich
approved these changes
Jan 30, 2025
Comment on lines
23
to
24
| onchange_res = self.order_line._onchange_product_packaging_id() | ||
| self.assertIn("warning", onchange_res) |
There was a problem hiding this comment.
These lines are never tested because of the ValidationError just above.
Could you move this to a separate test method?
|
|
||
| def test_packaging_level_can_be_sold(self): | ||
| self.order_line.write({"product_packaging_id": self.packaging_tu.id}) | ||
| with self.assertRaises(ValidationError): |
There was a problem hiding this comment.
nitpicking: use self.assertRaisesRegex and compare the actual error message
bizzappdev
force-pushed
the
17.0-mig-product_packaging_level_salable-BAD
branch
from
8d7471d to
1b35425
Compare
|
@ivantodorovich, changes are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency MR for module
product_packaging_level#1662