[16.0][FIX] product_variant_configurator: Solve recursion error. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix solves a recursion problem caused when the groupby refers to a field of a many2one model, and that model also has the same field name. In this example, the stock.valuation.layer.tree view contains a groupby product_id, and the product.product model already has a product_id field, relating to the same model. Without this code we would reach a recursion error
pedrobaeza
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Great hack for avoiding to do other massive changes, and well documented for not having future doubts about its usage. The test coverage is limited though, so this can fail again in the future (or future versions), but it will require a tour test for recreating the condition, so let's continue as is.
/ocabot merge patch
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 2b568a9. Thanks a lot for contributing to OCA. ❤️ |
|
@pedrobaeza thanks for your review. |
LoisRForgeFlow
deleted the
16.0-fix-product_variant_configurator-postprocess-tag-groupby
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix solves a recursion problem caused when the groupby refers to a field of a many2one model, and that model also has the same field name. In this example, the stock.valuation.layer.tree view contains a groupby product_id, and the product.product model already has a product_id field, relating to the same model. Without this code we would reach a recursion error.
Fixes #330
cc @JordiMForgeFlow @MarinaAForgeFlow @LauraCForgeFlow @pedrobaeza