[16.0][MIG] sale_variant_configurator: Migration to version 16.0 #353

carolinafernandez-tecnativa · 2024-05-16T17:02:21Z

Standard migration from 13 to 16.

This comes from module sale_product_variants from odoomrp/odoomrp-wip.

- saleable products for Sale Orders. - purchable products for Purchase Orders.

Depending on the onchange order loaded in runtime, description put in the SO line might be the one got from the regular way. With this, we assure we get the proper description, and also in the partner language (using the trick with the partner field).

* Use generic method for creating the variant if needed * Create the variant when the sales is already confirmed

for some reason, after the creation of the product, the sale.order.line was emptied (e.g. product_tmpl_id was False) -> the onchange would do nothing. I split the test in two, and in the second test, I create the product before creating the sale order line.

…omer language As the model `sale.order.line` doesn't have `partner_id` field, the description is not populated in the customer language, as the automatism put in product_configurator makes use of this trick. For not adding such field that can conflict with other parts, let's overwrite the methods that populate the description and pass upstream the customer language in the context. TT33029

sale_variant_configurator/models/sale_order.py

pedrobaeza · 2024-05-30T15:55:29Z

On v16, AFAIK, there are no more onchanges in sale.order.line. All are computed writable fields, so you shouldn't insist in making this to work with onchanges, but to adapt the mechanism overriding computed methods.

carolinafernandez-tecnativa · 2024-05-31T12:12:41Z

On v16, AFAIK, there are no more onchanges in sale.order.line. All are computed writable fields, so you shouldn't insist in making this to work with onchanges, but to adapt the mechanism overriding computed methods.

The only one missing was _compute_name, could you please check it now?

rousseldenis · 2024-06-18T07:21:41Z

/ocabot migration sale_variant_configurator

product_variant_sale_price/models/product_product.py

pedrobaeza · 2024-06-20T19:03:57Z

product_variant_configurator/models/product_configurator.py

@@ -48,6 +49,7 @@ class ProductConfigurator(models.AbstractModel):
    )
    def _compute_can_be_created(self):
        for rec in self:
+            rec.price_extra = sum(rec.mapped("product_attribute_ids.price_extra"))


A computed can't assign other value outside of their definition.

product_variant_configurator/models/product_configurator.py

sale_variant_configurator/models/sale_order.py

TT46599

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2024-06-22T08:17:31Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-353-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-06-22T08:22:02Z

Congratulations, your PR was merged at 652eb8d. Thanks a lot for contributing to OCA. ❤️

…lly bump versions Changes have been merged with nobump in PR OCA#353

pedrobaeza and others added 20 commits May 16, 2024 19:03

sale_variant_configurator: Migration to 9.0

a893f2f

This comes from module sale_product_variants from odoomrp/odoomrp-wip.

[MIG] sale_variant_configurator: Migration to 10.0

e1f83d8

[IMP] sale_variant_configurator: Avoid warning on non existing field

1a6f79f

[FIX] sale_variant_configurator: Don't choke on attribute name

0a447e4

[UPD] Update sale_variant_configurator.pot

9f98399

[MIG] sale_variant_configurator: Migration to 11.0

86c4c9e

[FIX] sale_variant_configurator: typo, field does not exist

a0af7b9

[FIX] *_variant_configurator: don't lose attribute on save

da24b61

[FIX] sale_variant_configurator: attribute lines are not created

4ec4f6a

[11.0][FIX] Filter products according to the view

48df1c7

- saleable products for Sale Orders. - purchable products for Purchase Orders.

[FIX] sale_variant_configurator: Don't lose sales description

6319f5f

[FIX+IMP] sale_variant_configurator: Variant creation when confirmed

d5a32ba

* Use generic method for creating the variant if needed * Create the variant when the sales is already confirmed

[FIX] sale_variant_configurator: Return value in action_confirm

2fecc32

[ADD] icon.png

abd4c10

"[IMP] sale_variant_configurator: black, isort, prettier"

2bfb9c9

[MIG] sale_variant_configurator: Migration to 13.0

0c804bf

[IMP] sale_variant_configurator: pre-commit stuff

2b98329

carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_variant_configurator branch 3 times, most recently from b7a0cb3 to 56719b7 Compare May 16, 2024 21:34

carolinafernandez-tecnativa marked this pull request as ready for review May 16, 2024 22:14

carolinafernandez-tecnativa mentioned this pull request May 17, 2024

[16.0][MIG] sale_product_variant_attribute_tax: Migration to version 16.0 #354

Merged

carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_variant_configurator branch from 56719b7 to 8fe21e7 Compare May 17, 2024 09:57

carolinafernandez-tecnativa mentioned this pull request May 17, 2024

[16.0][IMP] product_variant_configurator: Change development status to Production/Stable #355

Merged

carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_variant_configurator branch from 8fe21e7 to 2310a93 Compare May 17, 2024 10:24

pilarvargas-tecnativa reviewed May 17, 2024

View reviewed changes

sale_variant_configurator/models/sale_order.py Outdated Show resolved Hide resolved

pilarvargas-tecnativa reviewed May 17, 2024

View reviewed changes

sale_variant_configurator/models/sale_order.py Outdated Show resolved Hide resolved

pilarvargas-tecnativa reviewed May 30, 2024

View reviewed changes

sale_variant_configurator/models/sale_order.py Outdated Show resolved Hide resolved

pilarvargas-tecnativa reviewed May 30, 2024

View reviewed changes

sale_variant_configurator/models/sale_order.py Outdated Show resolved Hide resolved

carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_variant_configurator branch from 24ce980 to 3abf68d Compare May 30, 2024 15:53

carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_variant_configurator branch 2 times, most recently from ea65719 to 75bf84c Compare May 31, 2024 12:05

victoralmau force-pushed the 16.0-mig-sale_variant_configurator branch 4 times, most recently from 052e9f7 to 511e6a6 Compare June 18, 2024 07:01

rousseldenis added needs review migration labels Jun 18, 2024

rousseldenis reviewed Jun 18, 2024

View reviewed changes

product_variant_sale_price/models/product_product.py Show resolved Hide resolved

OCA-git-bot added this to the 16.0 milestone Jun 18, 2024

OCA-git-bot mentioned this pull request Jun 18, 2024

Migration to version 16.0 #272

Open

9 tasks

pedrobaeza reviewed Jun 20, 2024

View reviewed changes

[MIG] sale_variant_configurator: Migration to version 16.0

2351a7b

TT46599

victoralmau force-pushed the 16.0-mig-sale_variant_configurator branch from 511e6a6 to 2351a7b Compare June 21, 2024 06:45

pedrobaeza approved these changes Jun 22, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jun 22, 2024

OCA-git-bot merged commit e128707 into OCA:16.0 Jun 22, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 22, 2024

pedrobaeza deleted the 16.0-mig-sale_variant_configurator branch June 22, 2024 08:23

sbidoul added a commit to acsone/product-variant that referenced this pull request Aug 2, 2024

[FIX] product_variant_configurator, product_variant_sale_price: manua…

54d1e55

…lly bump versions Changes have been merged with nobump in PR OCA#353

sbidoul mentioned this pull request Aug 2, 2024

[FIX] product_variant_configurator, product_variant_sale_price: manually bump versions #365

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] sale_variant_configurator: Migration to version 16.0 #353

[16.0][MIG] sale_variant_configurator: Migration to version 16.0 #353

carolinafernandez-tecnativa commented May 16, 2024 •

edited

Loading

pedrobaeza commented May 30, 2024

carolinafernandez-tecnativa commented May 31, 2024

rousseldenis commented Jun 18, 2024

pedrobaeza Jun 20, 2024

pedrobaeza left a comment

OCA-git-bot commented Jun 22, 2024

OCA-git-bot commented Jun 22, 2024

[16.0][MIG] sale_variant_configurator: Migration to version 16.0 #353

[16.0][MIG] sale_variant_configurator: Migration to version 16.0 #353

Conversation

carolinafernandez-tecnativa commented May 16, 2024 • edited Loading

pedrobaeza commented May 30, 2024

carolinafernandez-tecnativa commented May 31, 2024

rousseldenis commented Jun 18, 2024

pedrobaeza Jun 20, 2024

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jun 22, 2024

OCA-git-bot commented Jun 22, 2024

carolinafernandez-tecnativa commented May 16, 2024 •

edited

Loading