Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] product_variant_configurator #357

Merged
merged 1 commit into from
May 23, 2024
Merged

[16.0][FIX] product_variant_configurator #357

merged 1 commit into from
May 23, 2024

Conversation

glitchov
Copy link

Add existence condition (name in _fields) to set name of product.configurator

@pedrobaeza pedrobaeza added this to the 16.0 milestone May 23, 2024
@pedrobaeza
Copy link
Member

Please remove [16.0] from the commit message. That's just only for the PR title.

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@glitchov glitchov force-pushed the 16.0-fix-product_variant_configurator-hda branch from 7a3f914 to c1b214d Compare May 23, 2024 07:43
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-357-by-pedrobaeza-bump-patch, awaiting test results.

@pedrobaeza pedrobaeza mentioned this pull request May 23, 2024
Closed
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-357-by-pedrobaeza-bump-patch:16.0 failed with output:

To https://github.com/OCA/product-variant
 ! [remote rejected] 16.0-ocabot-merge-pr-357-by-pedrobaeza-bump-patch -> 16.0 (cannot lock ref 'refs/heads/16.0': is at 76c2e3df417720d4acc23facd8a0dc3b7e80ee6c but expected 6c3746083039f60df2a883dc07b1f368284adc3e)
error: failed to push some refs to 'https://***@github.com/OCA/product-variant'

@OCA-git-bot OCA-git-bot merged commit 1691b59 into OCA:16.0 May 23, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 76c2e3d. Thanks a lot for contributing to OCA. ❤️

@ThomasBinsfeld ThomasBinsfeld deleted the 16.0-fix-product_variant_configurator-hda branch June 10, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@glitchov @pedrobaeza @OCA-git-bot @ThomasBinsfeld