Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] purchase_variant_configurator_on_confirm: Merged into purchase_variant_configurator and migration to 16.0 #362

Merged
merged 14 commits into from
Jun 28, 2024
Merged

[16.0][MIG] purchase_variant_configurator_on_confirm: Merged into purchase_variant_configurator and migration to 16.0 #362

merged 14 commits into from
Jun 28, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Jun 26, 2024 •
edited
Loading

Merged into purchase_variant_configurator and migration to 16.0

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT46597

sbidoul and others added 13 commits June 25, 2024 12:36
@sbidoul @victoralmau
purchase_variant_configurator_on_confirm
73da827 
OCA Transbot updated translations from Transifex
@chienandalu @victoralmau
[MIG] purchase_variant_configurator_on_confirm: Migration to 10.0
c82e658
@pedrobaeza @victoralmau
[FIX] *_variant_configurator*: Adjust things for proper purchase on c…
c323b84 
…onfirm

OCA Transbot updated translations from Transifex

[UPD] Update purchase_variant_configurator_on_confirm.pot
@ernestotejeda @victoralmau
[MIG] purchase_variant_configurator_on_confirm: Migration to 11.0
7dc4067
@pedrobaeza @victoralmau
[FIX] purchase_variant_configurator_on_confirm: Don't reset product o…
0f7e3fc 
…n template change if existing

If you have set product_id and product_tmpl_id and want to call onchange programatically, the
value is reset without real need. Changing the onchange for taking into account this prevents
the problem.

[UPD] README.rst

[UPD] Update purchase_variant_configurator_on_confirm.pot
@chienandalu @victoralmau
[IMP] : black, isort, prettier
b5d646f
@chienandalu @victoralmau
[MIG] purchase_variant_configurator_on_confirm: Migration to 13.0
120a304 
[UPD] Update purchase_variant_configurator_on_confirm.pot

[UPD] README.rst
@anasuarez1 @victoralmau
Translated using Weblate (Spanish)
7fd8453 
Currently translated at 100.0% (4 of 4 strings)

Translation: product-variant-13.0/product-variant-13.0-purchase_variant_configurator_on_confirm
Translate-URL: https://translation.odoo-community.org/projects/product-variant-13-0/product-variant-13-0-purchase_variant_configurator_on_confirm/es/
@ibuioli @victoralmau
Added translation using Weblate (Spanish (Argentina))
ccb8734 
Translated using Weblate (Spanish (Argentina))

Currently translated at 100.0% (7 of 7 strings)

Translation: product-variant-13.0/product-variant-13.0-purchase_variant_configurator_on_confirm
Translate-URL: https://translation.odoo-community.org/projects/product-variant-13-0/product-variant-13-0-purchase_variant_configurator_on_confirm/es_AR/
@francesco-ooops @victoralmau
Translated using Weblate (Italian)
79fe53a 
Currently translated at 100.0% (4 of 4 strings)

Translation: product-variant-13.0/product-variant-13.0-purchase_variant_configurator_on_confirm
Translate-URL: https://translation.odoo-community.org/projects/product-variant-13-0/product-variant-13-0-purchase_variant_configurator_on_confirm/it/
@mymage @victoralmau
Translated using Weblate (Italian)
b149031 
Currently translated at 100.0% (4 of 4 strings)

Translation: product-variant-13.0/product-variant-13.0-purchase_variant_configurator_on_confirm
Translate-URL: https://translation.odoo-community.org/projects/product-variant-13-0/product-variant-13-0-purchase_variant_configurator_on_confirm/it/

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-variant-13.0/product-variant-13.0-purchase_variant_configurator_on_confirm
Translate-URL: https://translation.odoo-community.org/projects/product-variant-13-0/product-variant-13-0-purchase_variant_configurator_on_confirm/
@mymage @victoralmau
Translated using Weblate (Italian)
a9a8d8a 
Currently translated at 100.0% (7 of 7 strings)

Translation: product-variant-13.0/product-variant-13.0-purchase_variant_configurator_on_confirm
Translate-URL: https://translation.odoo-community.org/projects/product-variant-13-0/product-variant-13-0-purchase_variant_configurator_on_confirm/it/
@victoralmau
[IMP] purchase_variant_configurator_on_confirm: pre-commit stuff
b7bbaad
@victoralmau victoralmau force-pushed the 16.0-mig-purchase_variant_configurator_on_confirm branch from 1294ff6 to 91b45e3 Compare June 26, 2024 07:55
chienandalu
chienandalu approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine.

An expanded readme with at least a functional testing case would be welcome

@pedrobaeza
Copy link
Member

In fact, I think this feature should be integrated into purchase_variant_configurator_on_confirm as an option to configure at system or company level.

@victoralmau
Copy link
Member Author

In fact, I think this feature should be integrated into purchase_variant_configurator_on_confirm as an option to configure at system or company level.

I guess you mean to add this functionality to purchase_variant_configurator with a new field in res.config.settings, right?

What is the way to do it? All in the migration commit?

@pedrobaeza
Copy link
Member

Yeah, that's it, sorry. You can do it in the migration commit, yes.

@victoralmau
Copy link
Member Author

Preparing to move everything to purchase_variant_configurator I'm not sure that's the best decision. We want to add this https://github.com/OCA/product-variant/blob/13.0/purchase_variant_configurator_on_confirm/models/purchase_order.py#L41 and the _sql_constraints to everyone? I think not, and maybe for that reason it was left in a separate module.

@pedrobaeza
Copy link
Member

I think it can be removed at DB level, and enforced in screen depending on the parameter.

@victoralmau victoralmau force-pushed the 16.0-mig-purchase_variant_configurator_on_confirm branch 2 times, most recently from c747b6e to fe88c0e Compare June 27, 2024 12:22
@victoralmau victoralmau changed the title [16.0][MIG] purchase_variant_configurator_on_confirm: Migration to 16.0 [16.0][MIG] purchase_variant_configurator_on_confirm: Merged into purchase_variant_configurator and migration to 16.0 Jun 27, 2024
@victoralmau
Copy link
Member Author

Changes done.

@pedrobaeza
Copy link
Member

/ocabot migration purchase_variant_configurator_on_confirm

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 27, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 27, 2024
Open
9 tasks
@victoralmau victoralmau force-pushed the 16.0-mig-purchase_variant_configurator_on_confirm branch from fe88c0e to a711352 Compare June 28, 2024 06:30
@victoralmau
Copy link
Member Author

Changes done.

@victoralmau
[MIG] purchase_variant_configurator_on_confirm: Merged into purchase_…
e1d6c4e 
…variant_configurator and migration to 16.0

TT46597
@victoralmau victoralmau force-pushed the 16.0-mig-purchase_variant_configurator_on_confirm branch from a711352 to e1d6c4e Compare June 28, 2024 07:22
pedrobaeza
pedrobaeza approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-362-by-pedrobaeza-bump-major, awaiting test results.

@pedrobaeza
Copy link
Member

Please add the corresponding merging in OpenUpgrade.

@OCA-git-bot OCA-git-bot merged commit 8475749 into OCA:16.0 Jun 28, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5899a80. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-purchase_variant_configurator_on_confirm branch June 28, 2024 07:32
@victoralmau victoralmau mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
10 participants
@victoralmau @pedrobaeza @OCA-git-bot @chienandalu @sbidoul @ernestotejeda @anasuarez1 @ibuioli @francesco-ooops @mymage