Add myself as a maintainer #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think your contribution is still very little for taking this role, and you shouldn't put 2 github logins. Continue contributing a bit and learning the OCA procedures and ask again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would really like to be able to merge my changes to this module. I have not seen any activity on this repo in a while for 17.0. Clearly someone needs to do this job, and I am reluctantly volunteering. If someone merges my changes, I'll let it go and I don't need to be a maintainer on this module.
Here is my PR that I worked on: #363. It passes all tests and it works.