Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] purchase_tier_validation: Add decoration to purchase tree view when orders have been rejected or approved. #1440

Merged

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Apr 28, 2022

Add decoration to purchase tree view when orders have been rejected or approved.

Locked by:

ejemplo-v14

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT33369

@pedrobaeza
Copy link
Member

I don't think whole row should be decorated. This should be one optional column (hidden by default I would say) with such colors now that we have this option.

Waiting also for @LoisRForgeFlow's opinion on this.

@pedrobaeza pedrobaeza added this to the 14.0 milestone Apr 28, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 15, 2023
@LoisRForgeFlow
Copy link
Contributor

I don't think whole row should be decorated. This should be one optional column (hidden by default I would say) with such colors now that we have this option.

Waiting also for @LoisRForgeFlow's opinion on this.

Sorry I missed this one. Yes, I like Pedro's option better, that new column can have colored bubbles depending on the validation status.

@victoralmau
Copy link
Member Author

Sorry, I don't know exactly what you want to add, can you add a concrete example?

@LoisRForgeFlow
Copy link
Contributor

@victoralmau I mean that you can do what Pedro suggested + take advantage of the decoration-success and decoration-danger in the field (to show a green or red background on the field)

Similar to most status fields in tree views (example in sales):

image

pseudocode: <field name="validation_status" decoration-danger=validatoin_status == "rejected" .../>

validation status doesn't exist, but can be added as a compute field in base_tier_validation if you think this approach is good.

@victoralmau victoralmau force-pushed the 14.0-imp-purchase_tier_validation-tree_view branch from c816bf9 to cc07a8f Compare October 17, 2023 15:07
@victoralmau
Copy link
Member Author

Thanks, changes done.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 22, 2023
@victoralmau victoralmau force-pushed the 14.0-imp-purchase_tier_validation-tree_view branch from cc07a8f to f758498 Compare October 23, 2023 11:56
@victoralmau
Copy link
Member Author

Rebase done, ready for review.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1440-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d0cc4b8 into OCA:14.0 Oct 23, 2023
13 of 14 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 04eb26c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants