-
-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][IMP] purchase_tier_validation: Add decoration to purchase tree view when orders have been rejected or approved. #1440
[14.0][IMP] purchase_tier_validation: Add decoration to purchase tree view when orders have been rejected or approved. #1440
Conversation
I don't think whole row should be decorated. This should be one optional column (hidden by default I would say) with such colors now that we have this option. Waiting also for @LoisRForgeFlow's opinion on this. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Sorry I missed this one. Yes, I like Pedro's option better, that new column can have colored bubbles depending on the validation status. |
Sorry, I don't know exactly what you want to add, can you add a concrete example? |
@victoralmau I mean that you can do what Pedro suggested + take advantage of the decoration-success and decoration-danger in the field (to show a green or red background on the field) Similar to most status fields in tree views (example in sales): pseudocode: validation status doesn't exist, but can be added as a compute field in base_tier_validation if you think this approach is good. |
c816bf9
to
cc07a8f
Compare
Thanks, changes done. |
…e widget to purchase tree view. TT33369
cc07a8f
to
f758498
Compare
Rebase done, ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge minor
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 04eb26c. Thanks a lot for contributing to OCA. ❤️ |
Add decoration to purchase tree view when orders have been rejected or approved.
Locked by:
Please @pedrobaeza and @chienandalu can you review it?
@Tecnativa TT33369