Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] rma_sale: Set analytic_account_id on refund from sale.order #374

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[14.0][IMP] rma_sale: Set analytic_account_id on refund from sale.order #374

merged 1 commit into from
Nov 7, 2023

Conversation

mt-software-de
Copy link
Contributor

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @ernestotejeda,
some modules you are maintaining are being modified, check this out!

@mt-software-de mt-software-de force-pushed the 14-keep-analytic-account branch from b44b68e to 20fbbbc Compare November 1, 2023 22:42
pedrobaeza
pedrobaeza reviewed Nov 2, 2023
View reviewed changes
rma_sale/models/rma.py Outdated Show resolved Hide resolved
@mt-software-de mt-software-de force-pushed the 14-keep-analytic-account branch from 20fbbbc to 51c03d1 Compare November 2, 2023 15:07
pedrobaeza
pedrobaeza reviewed Nov 2, 2023
View reviewed changes
rma_sale/tests/test_rma_sale.py Outdated Show resolved Hide resolved
rma_sale/tests/test_rma_sale.py Show resolved Hide resolved
@pedrobaeza pedrobaeza added this to the 14.0 milestone Nov 2, 2023
@mt-software-de mt-software-de force-pushed the 14-keep-analytic-account branch from 51c03d1 to 1fb28e2 Compare November 3, 2023 10:51
chienandalu
chienandalu approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mt-software-de 👍

@pedrobaeza
Copy link
Member

/ocabot merge patch

Can you please fw-port it to upper versions?

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-374-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 3, 2023
@OCA-git-bot
Merge PR #374 into 14.0
c7252e3 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-374-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

#373 should be finished to this be mergeable.

@chienandalu
Copy link
Member

Rebase to get 🟢 CIs

@mt-software-de mt-software-de force-pushed the 14-keep-analytic-account branch from 1fb28e2 to b5778d3 Compare November 7, 2023 16:52
@mt-software-de
Copy link
Contributor Author

Rebase to get 🟢 CIs

done.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-374-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f3988c0 into OCA:14.0 Nov 7, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e2952ac. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilshamerlinck nilshamerlinck nilshamerlinck left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mt-software-de @OCA-git-bot @pedrobaeza @chienandalu @nilshamerlinck