[15.0][IMP] RMA - refactor to use procurement run #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chienandalu, @chiendandalu, |
|
Ping @chienandalu |
|
Ping @pedrobaeza and @chienandalu |
pedrobaeza
reviewed
May 17, 2024
There was a problem hiding this comment.
I know that most of the changes are not yours, but the diff is barely impossible to follow due to unneeded changes like passing methods from self.ensure_one to multi-record with no reason, and excessive unneeded hooks. Please clean up for being able to check something.
victoralmau
force-pushed
the
15.0-imp-rma-TT48789
branch
from
7b2dfd2 to
ce24574
Compare
Co-authored-by: Michael Tietz
victoralmau
force-pushed
the
15.0-imp-rma-TT48789
branch
2 times, most recently
from
421d078 to
d9d2222
Compare
|
Changes done to reduce diff and methods. |
victoralmau
force-pushed
the
15.0-imp-rma-TT48789
branch
from
d9d2222 to
2179cc5
Compare
4 tasks
|
Superseed #392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWP from 14.0: #350
Changes done:
rma_deliverychanges.reception_move_idstoreception_move_idfieldPlease @pedrobaeza and @chienandalu can you review it?
@Tecnativa TT48789