Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_order_qty_change_no_recompute: Migration to 16.0 #2365

Closed
wants to merge 15 commits into from
Closed

[16.0][MIG] sale_order_qty_change_no_recompute: Migration to 16.0 #2365

wants to merge 15 commits into from

Conversation

ignissak
Copy link
Contributor

@ignissak ignissak commented Feb 7, 2023

victoralmau and others added 15 commits February 7, 2023 15:09
@victoralmau @ignissak
[ADD] sale_order_qty_change_no_recompute: Prevent recompute if only q…
c30899b 
…uantity has changed in sale order line
@pedrobaeza @ignissak
[FIX] sale_order_qty_change_no_recompute: Proper way for removing onc…
27b7ab1 
…hange

The _origin trick is not valid, as it doesn't reflect the state before
the onchange, only the saved copy (if any).
@victoralmau @ignissak
[IMP] sale_order_qty_change_no_recompute: Improve tests
290006c
@victoralmau @ignissak
[IMP] sale_order_qty_change_no_recompute: black, isort, prettier
0c5840a
@victoralmau @ignissak
[MIG] sale_order_qty_change_no_recompute: Migration to 14.0
2c09f1b
@oca-travis @ignissak
[UPD] Update sale_order_qty_change_no_recompute.pot
63c92e6
@victoralmau @ignissak
[IMP] sale_order_qty_change_no_recompute: Add context in test to prev…
95ace5d 
…ent onchange quantity and some possible related error in another addons.
@OCA-git-bot @ignissak
sale_order_qty_change_no_recompute 14.0.1.0.1
ab5dc4b
@pedrobaeza @ignissak
[IMP] sale_order_qty_change_no_recompute: Block also uom onchange
aa99b58 
Changing that field shouldn't trigger price recomputation as well.

TT32663
@cesar-tecnativa @ignissak
[15.0][MIG] sale_order_qty_change_no_recompute: migrate sale_order_qt…
c7cbef0 
…y_change_no_recompute
@ignissak
[UPD] Update sale_order_qty_change_no_recompute.pot
c1a25e4
@OCA-git-bot @ignissak
[UPD] README.rst
a7bd786
@CarlosRoca13 @ignissak
[IMP] sale_order_qty_change_no_recompute: Change SavepointCase by Tra…
3db905a 
…nsactrionCase
@ignissak
[IMP] sale_order_qty_change_no_recompute: pre-commit stuff
05e4ce6
@ignissak
[MIG] sale_order_qty_change_no_recompute: Migration to 16.0
7adc17e
@ignissak ignissak mentioned this pull request Feb 7, 2023
Open
100 tasks
@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_qty_change_no_recompute

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 9, 2023
amarcosg
amarcosg approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@amarcosg amarcosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza requested changes Mar 14, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding that field is an overhead that shouldn't be for something transient like this

@rousseldenis
Copy link
Contributor

@ignissak

@OCA-git-bot OCA-git-bot mentioned this pull request Apr 27, 2023
Merged
@pedrobaeza
Copy link
Member

A proper migration has been implemented in #2473, as this one only covers changes in the UI, not by code, and it uses an extra field with possible side effects, so closing.

@pedrobaeza pedrobaeza closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

@amarcosg amarcosg amarcosg approved these changes

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@ignissak @rousseldenis @OCA-git-bot @pedrobaeza @amarcosg @victoralmau @oca-travis @cesar-tecnativa @CarlosRoca13