[16.0][MIG] sale_order_secondary_unit #3022
Open
+1,702
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-pelykh
force-pushed
the
16.0-mig-sale_order_secondary_unit
branch
5 times, most recently
from
9dd9058 to
b7476c9
Compare
alexey-pelykh
commented
Mar 16, 2024
.copier-answers.yml
Outdated
| @@ -17,6 +17,7 @@ org_name: Odoo Community Association (OCA) | |||
| org_slug: OCA | |||
| rebel_module_groups: | |||
| - sale_packaging_default,sale_order_product_recommendation,sale_order_product_recommendation_packaging_default,sale_order_product_recommendation_elaboration | |||
| - sale_order_qty_change_no_recompute | |||
There was a problem hiding this comment.
@pedrobaeza @victoralmau was there a specific reason why this module was not marked as rebel?
alexey-pelykh
force-pushed
the
16.0-mig-sale_order_secondary_unit
branch
6 times, most recently
from
13b23b7 to
744c375
Compare
alexey-pelykh
commented
Mar 16, 2024
| attrs="{'readonly': [('state', 'in', ('done', 'cancel'))]}" | ||
| optional="show" | ||
| /> | ||
| <field name="secondary_uom_unit_price" readonly="1" optional="show" /> |
There was a problem hiding this comment.
@sergio-teruel Why the field was deleted from the view yet kept in the model?
alexey-pelykh
force-pushed
the
16.0-mig-sale_order_secondary_unit
branch
17 times, most recently
from
8cbac8e to
e82d685
Compare
As the test should only test that no change on the UoM quantity is done when modifying the secondary unit, we remember the existing quantity and compare it later with the final value, instead of testing against a fixed value, so any interaction with other modules don't interfere.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_secondary_unit/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_secondary_unit/
Currently translated at 100.0% (18 of 18 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_secondary_unit/es/
Currently translated at 38.8% (7 of 18 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_secondary_unit/fi/
- Include context keys for avoiding mail operations overhead.
…uom to variants TT45597
…ary_uom_qty is filled
…y quantity fields optional TT49686
…ndary uom without product in sale order line TT51683
alexey-pelykh
force-pushed
the
16.0-mig-sale_order_secondary_unit
branch
from
221c07c to
9b2d3a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.