Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when order is created by api #3258

Open
wants to merge 6 commits into
base: 16.0
Choose a base branch
from
Open

Conversation

sefirosweb
Copy link

This fix when you want to create order via API and you want use discount_fixed instead "discount" rate

Without that the sales_order_line is created with discount_fixed but discount is 0

image

This fix when you want to create order via API and you want use discount_fixed instead "discount" rate

Without that the sales_order_line is created with discount_fixed  but discount is 0
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sefirosweb Could you fix this?

Moreover, adding a test case for that flow should be great.

@sefirosweb
Copy link
Author

@rousseldenis I saw a bit bug when is creating the records i fixed them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants