[17.0] [MIG] sales_team_security_sale: Migration to 17.0 #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lef-adhoc
force-pushed
the
17.0-h-82619-cem
branch
from
bb7bcf5 to
00a3ade
Compare
carlos-lopez-tecnativa
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
LGTM
TT52442
@Tecnativa @pedrobaeza could you please review this.
carlos-lopez-tecnativa
suggested changes
Jan 7, 2025
| <field name="model_id" ref="sale.model_sale_order" /> | ||
| <field | ||
| name="domain_force" | ||
| >['|', '|', ('user_id', '=', user.id), ('user_id', '=', False), '|', ('team_id', '=', user.sale_team_id.id),('team_id', '=', False)] |
There was a problem hiding this comment.
I think this can be simplified to: What do you think?
Suggested change
| >['|', '|', ('user_id', '=', user.id), ('user_id', '=', False), '|', ('team_id', '=', user.sale_team_id.id),('team_id', '=', False)] | |
| >['|', ('user_id', 'in', [user.id, False]), ('team_id', 'in', [user.sale_team_id.id, False])] |
lef-adhoc
force-pushed
the
17.0-h-82619-cem
branch
from
00a3ade to
3c33ee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.