[16.0] [FIX] sale_order_line_date: remove TypeError

[LuciaMarchalFactorLibre]

FL-556-5216

There is no checking that commitment_date has a correct value, only that it is set.
File "sale-workflow/sale_order_line_date/models/sale_order_line.py", line 40, in write

    def write(self, vals):
        res = super().write(vals)
        moves_to_upd = set()
        if "commitment_date" in vals:
            for move in self.move_ids:
                if move.state not in ["cancel", "done"]:
                    moves_to_upd.add(move.id)
        if moves_to_upd:
            self.env["stock.move"].browse(moves_to_upd).write(
                {"date_deadline": vals.get("commitment_date")} # <-----------------------
            )
        return res

Translating an empty value is not done correctly in the stock module
File "/odoo-base/odoo-server/addons/stock/models/stock_move.py", line 698, in write

if 'date_deadline' in vals:
    self._set_date_deadline(vals.get('date_deadline')) # <---------------------

File "/odoo-base/odoo-server/addons/stock/models/stock_move.py", line 539, in _set_date_deadline

if move.date_deadline:
    delta = move.date_deadline - fields.Datetime.to_datetime(new_deadline) # <------------------------

[mmequignon]

Why not doing everything in the if block, and checking that "commitment_date" is correctly set only once?

if vals.get("commitment_date"):
    moves_to_upd = set()
    for move in self.move_ids:
         [...]
    if moves_to_upd:
         [...]

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖