[FIX] membership_extension: support restarted memberships #191
+104
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a membership got cancelled and, later, restarted, we still had a cancellation date set, leading to the sensation that it was still cancelled. With this refactor, when a cancellation date is earlier than a future start date, cancellation info is removed from the partner. BTW I improved a few things: - Removed old dead code that is no longer necessary in v16. - Fix a test that was checking what happened when a membership line was cancelled before its start date. It seems a wrong use case because memberships are only supposed to be cancelled during the membership, and not before starting it. - Free members need to be considered members too. - Migration script. @moduon MT-8237
Before this fix, when creating many memberships at once, only the last one was really created. @moduon MT-8237
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at 7965a0f. Thanks a lot for contributing to OCA. ❤️ |
yajo
deleted the
16.0-membership_extension-restarted_membership_is_not_cancelled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a membership got cancelled and, later, restarted, we still had a cancellation date set, leading to the sensation that it was still cancelled.
With this refactor, when a cancellation date is earlier than a future start date, cancellation info is removed from the partner.
Before:
After:
BTW I improved a few things:
@moduon MT-8237