Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] bookstore_mgmt_google_books_api: New module bookstore_mgmt_google_books_api #20

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Nov 6, 2024

This module add the possibility to import book information from Google Books via API calls

cc https://github.com/APSL 163009
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review

@peluko00 peluko00 force-pushed the 17.0-add-bookstore_mgmt_google_books_api branch from 3fa7591 to 0ceb512 Compare November 6, 2024 11:24
@peluko00 peluko00 marked this pull request as ready for review November 6, 2024 11:24
@peluko00 peluko00 force-pushed the 17.0-add-bookstore_mgmt_google_books_api branch from 0ceb512 to a9de767 Compare November 6, 2024 11:25
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, testes in runboat and code review

@peluko00 peluko00 force-pushed the 17.0-add-bookstore_mgmt_google_books_api branch from a9de767 to f20322b Compare November 6, 2024 14:53
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code review and tested in runboat 👍

@miquelalzanillas
Copy link

miquelalzanillas commented Nov 7, 2024

Hi @peluko00 ,

Thanks. I think we still can improve some points.

Book Synopsis
In case of an e-commerce, the book synopsis will not be displayed in the product page because is only stored in an internal product field.

Book Cover Image Size
Can we check the image size synced from Google? Seems too small in an e-commerce published product page. May can be bigger?

Massive Sync
I think it will be a need. But an action available from the book list view to select several records to sync would be very nice here.

@peluko00 peluko00 force-pushed the 17.0-add-bookstore_mgmt_google_books_api branch 2 times, most recently from 53d1e10 to b7e14c4 Compare November 7, 2024 08:36
@peluko00 peluko00 force-pushed the 17.0-add-bookstore_mgmt_google_books_api branch from b7e14c4 to 87667f4 Compare November 11, 2024 09:04
@peluko00
Copy link
Author

Hi @pedrobaeza, sorry for ping you but this pr is ready and only needs a PSC to review it. Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 17.0 milestone Nov 11, 2024
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-20-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2964abe into OCA:17.0 Nov 11, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7ed5919. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants