Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] bookstore_mgmt: Fix groups permissions #24

Merged
merged 1 commit into from
Dec 29, 2024
Merged

[17.0][FIX] bookstore_mgmt: Fix groups permissions #24

merged 1 commit into from
Dec 29, 2024

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Dec 24, 2024 •
edited
Loading

This fix adjusts the group permissions.

@ppyczko @BernatObrador @miquelalzanillas Please review

cc https://github.com/APSL 165153

@OCA-git-bot
Copy link
Contributor

Hi @miquelalzanillas,
some modules you are maintaining are being modified, check this out!

BernatObrador
BernatObrador approved these changes Dec 24, 2024
View reviewed changes
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ppyczko
ppyczko approved these changes Dec 24, 2024
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peluko00
Copy link
Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-24-by-peluko00-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 27, 2024
@OCA-git-bot
Merge PR #24 into 17.0
7c4c6e9 
Signed-off-by peluko00
@OCA-git-bot
Copy link
Contributor

@peluko00 your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-24-by-peluko00-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-24-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6e55600 into OCA:17.0 Dec 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fc25a1b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppyczko ppyczko ppyczko approved these changes

@BernatObrador BernatObrador BernatObrador approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peluko00 @OCA-git-bot @pedrobaeza @BernatObrador @ppyczko