Implement FromODataUriAttribute & ODataQueryParameterBindingAttribute. #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robward-ms
force-pushed
the
NetCore-1142-1149
branch
2 times, most recently
from
f8f6cc5 to
787a57d
Compare
AlanWong-MS
reviewed
Dec 7, 2017
| { | ||
| Contract.Assert(parameterType != null); | ||
|
|
||
| Contract.Assert(parameterType != null); |
AlanWong-MS
reviewed
Dec 7, 2017
| if (entityClrType == null) | ||
| { | ||
| entityClrType = GetEntityClrTypeFromActionReturnType(actionDescriptor); | ||
|
|
There was a problem hiding this comment.
Empty line. Not sure if stylecop catches this.
There was a problem hiding this comment.
It should, let me look into that...
genusP
reviewed
Dec 7, 2017
| @@ -23,6 +23,10 @@ namespace Microsoft.AspNet.OData.Formatter | |||
| /// <summary> | |||
| /// Provides a <see cref="IModelBinder"/> for EDM primitive types. | |||
| /// </summary> | |||
| /// <remarks> | |||
| /// This class is similar to ODataModelBinder in AspNetCore. The flow is similar but the | |||
There was a problem hiding this comment.
File located in AspNet project, you write AspNetCore
There was a problem hiding this comment.
Correct., my intention is to cross-link the files since a fix would likely need to make it into both files.
genusP
reviewed
Dec 7, 2017
| /// A model binder for ODataParameterValue values. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// This class is similar to ODataModelBinderProvider in AspNet. The flow is similar but the |
There was a problem hiding this comment.
File located in AspNetCore project, you write AspNet
There was a problem hiding this comment.
Correct., my intention is to cross-link the files since a fix would likely need to make it into both files.
Implement NonValidatingParameterBindingAttribute. Implement ODataNullValueMessageHandler as a IResultFilter. Implement ODataQueryParameterBindingAttribute. Fixed $count calculation in ODataFeature.TotalCount. Fixed an ETag is where the etag handler was not being retrieved from the per-route service container. Refactor EnableQueryAttribute to move model retrieval to ActionDescriptorExtensions.
robward-ms
force-pushed
the
NetCore-1142-1149
branch
from
787a57d to
c8c8f31
Compare
This was referenced Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request makes progress on issues #975, #939, #772, #628, #229,
This pull request fixes issues #1142, #1149, #1153
Description
Implement NonValidatingParameterBindingAttribute.
Implement ODataNullValueMessageHandler as a IResultFilter.
Implement ODataQueryParameterBindingAttribute.
Fixed $count calculation in ODataFeature.TotalCount.
Fixed an ETag is where the etag handler was not being retrieved from the per-route service container.
Refactor EnableQueryAttribute to move model retrieval to ActionDescriptorExtensions.
Checklist (Uncheck if it is not completed)
Additional work necessary
Refactor Batching and Formatting for AspNetCore.
Port Unit Tests to NetCore & Xunit 2.0
Port E2E Tests to NetCore & Xunit 2.0