Issue 7357 v2 #2202
Open
Issue 7357 v2 #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests exhibiting issue on filestore Tickets: #7346 #7347
Make sure the result are correct with regards to filestore keyword impact.
5 tasks
catenacyber
reviewed
Jan 21, 2025
| @@ -0,0 +1,2 @@ | |||
| alert http any any -> any any (msg:"alert png images"; http.uri; content:".png"; nocase; sid:1; rev:1;) | |||
| alert http any any -> any any (msg:"store png images"; http.uri; content:".png"; nocase; filestore; sid:2; rev:1;) | |||
There was a problem hiding this comment.
I do not think this should match, the others look ok
There was a problem hiding this comment.
see discussion at OISF/suricata#12312 (comment)
catenacyber
reviewed
Jan 21, 2025
| @@ -0,0 +1 @@ | |||
| alert http any any -> any any (http.uri; content: "toto"; filestore; file.data; content: "tata"; sid:1;) | |||
There was a problem hiding this comment.
Thanks for adding this, but I think my remark was about false positive (instead of false negative)
So, we want to check that alert http any any -> any any (http.uri; content: "toto"; filestore; file.data; content: "titi"; sid:2;) does not match
catenacyber
added
requires suricata pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of #2111:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7357