Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect: add test for ldap.request.operation - draft v2 #2211

Conversation

AkakiAlice
Copy link
Contributor

@AkakiAlice AkakiAlice commented Jan 3, 2025

Ticket: 7453

Description:

  • Add S-V test for ldap.request.operation keyword

test.rules changes:

  • Add tests for str arguments
  • Add tests for ldap.responses.operation

test.yaml changes:

  • Reuse pcap from ../ldap-search/ldap.pcap
  • Test pcap_cnt

README.md changes:

  • Change description

Not included yet:

  • Tests for arguments all any count when using ldap.responses.operation

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7453
Suricata PR: OISF/suricata#12321
Previous PR: #2206

@AkakiAlice AkakiAlice force-pushed the detect-ldap-request-operation-7453-v2 branch from 068193e to 1eecc71 Compare January 3, 2025 16:37
@AkakiAlice
Copy link
Contributor Author

I included eve.json because I don't understand why I can´t match pcap_cnt: 9 for search_result_done

@catenacyber
Copy link
Collaborator

I included eve.json because I don't understand why I can´t match pcap_cnt: 9 for search_result_done

Suricata acts on acked data, unless used in inline mode.
You can use --set stream.inline=true for this.

Is it your problem ?

@catenacyber
Copy link
Collaborator

And the signatures are inspected for the packet in the right direction

@catenacyber
Copy link
Collaborator

so, search_result_entry is only at packet 8 because it is the first packet in the good direction after having asked the data

In the end, a pseudo-packet is created to timeout flows and process what is remaining in them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants