detect/integers: test enum with negated strings - v2 #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: #7513
This was referenced Jan 27, 2025
catenacyber
reviewed
Jan 27, 2025
|
|
||
| checks: | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: websocket | ||
| websocket.opcode: ping | ||
| websocket.opcode: ping # ping is not pong | ||
| pcap_cnt: 8 | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: websocket |
There was a problem hiding this comment.
You want to add new checks for event_type: alert (and the absence of it)
catenacyber
reviewed
Jan 27, 2025
| @@ -0,0 +1,2 @@ | |||
| alert websocket any any -> any any (msg:"There is no pong opcode in this packet"; websocket.opcode:!pong; sid:1;) | |||
| alert websocket any any -> any any (msg:"There is no ping opcode in this packet"; websocket.opcode:!ping; sid:2;) | |||
There was a problem hiding this comment.
You can also have !text to make it maybe clearer
catenacyber
requested changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #7513
Description:
Changes:
websocket-pingRedmine ticket: https://redmine.openinfosecfoundation.org/issues/7513
Suricata PR: OISF/suricata#12484
Previous PR: #2250