rule-types: add more rules - v2 #2259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To accompany rule types documentation. Added these separately, as they require extra config files. As the test name still includes `rule-types`, it's still possible to both batches of tests at once. Related to Task #https://redmine.openinfosecfoundation.org/issues/7031
Add test for the app_tx rule type for the engine-analysis report to accompany rule types documentation. Related to Task #7031
Add tests for the app_layer rule type for the engine-analysis report to accompany rule types documentation. Related to Task #7031
Test protocol detection only engine-analysis tests to accompany rule types documentation. Related to Task #7031
Add engine-analysis tests for like_ip_only rule type, to accompany rule types documentation. Related to Task #7031
To accompany rule types documentation. Related to Task #7031
To accompany rule types documentation. Related to Task #7031
To accompany rule types documentation. Related to Task #7031
To accompany the Rule Types documentation. Related to Task #7031
To accompany Rule Types documentation. Related to Task #7031
|
There will be a follow up work to add more rules to each of the rule types tests, but for now decided to go with a shorter version that would be easier to review to ensure we have it merged as we merge the doc. |
victorjulien
approved these changes
Jan 28, 2025
|
Merged in #2261, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #2153
To accompany Rule types documentation.
Changes:
Ticket
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/7031