Pgsql cancel req 6577/v2 #10019
Closed
Pgsql cancel req 6577/v2 #10019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is called so many times that it seems to make sense that we use a function for this.
This message can occur in a few different scenarios, so it's important that the parser can properly recognize it. TODO: - check/bind cancel request message to correct transaction/state based on pid/backend_key? -- not sure we can - Add documentation, might be the only thing missing, for now. For later, when we have events, we might want to include those here. Task OISF#6577
|
WARNING:
Pipeline 16966 |
|
Replaced by: #10036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #10000 <3
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6577
Describe changes:
TODO:
To consider.i: Given what was indicated above, I don't think we can easily correlate the cancel request message with the other tx, as it's from a different flow altogether
To consider.ii: if we should create an event in case a cancel request is sent with invalid (fake pid and backend key) data, and how would that work, if different flows
SV_BRANCH=OISF/suricata-verify#1530