Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/ssh: remove deprecated keywords #11332

Closed

Conversation

catenacyber
Copy link
Contributor

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (6256391) to head (7dfd7c6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11332      +/-   ##
==========================================
- Coverage   82.41%   82.39%   -0.03%     
==========================================
  Files         934      931       -3     
  Lines      247239   246682     -557     
==========================================
- Hits       203773   203251     -522     
+ Misses      43466    43431      -35     
Flag Coverage Δ
fuzzcorpus 60.22% <ø> (-0.03%) ⬇️
livemode 18.75% <ø> (+<0.01%) ⬆️
pcap 43.66% <ø> (-0.14%) ⬇️
suricata-verify 61.36% <ø> (+0.01%) ⬆️
unittests 59.25% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21150

@catenacyber
Copy link
Contributor Author

I should also remove the documentation for these keywords...

@catenacyber catenacyber marked this pull request as draft July 4, 2024 13:53
@catenacyber
Copy link
Contributor Author

Continued in #11448

@catenacyber catenacyber closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants