detect/dataset: delay set operation after signature full match v6 #11704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set operation of dataset keyword was done even if signature did not fully match. This patch changes the behavior of the dataset keyword to do a match and a post match for the set operation. The postmatch retrieves the data and set it in the buffer. Increases postmatch capability to do applayertxmatch, and this get the data from a tx buffer. Ticket: OISF#5576
catenacyber
commented
Sep 3, 2024
|
|
||
| DetectEngineAppInspectionEngine *a = s->app_inspect; | ||
| while (a != NULL) { | ||
| if (a->sm_list == sd->list && a->alproto == f->alproto) { |
There was a problem hiding this comment.
Can we quickly know if sd->list is a app engine or a pkt one ?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11704 +/- ##
=======================================
Coverage 82.63% 82.64%
=======================================
Files 919 919
Lines 248925 248979 +54
=======================================
+ Hits 205703 205765 +62
+ Misses 43222 43214 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: ERROR: QA failed on SURI_TLPR1_suri_time.
Pipeline 22328 |
|
Clean in #11714 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5576
Describe changes:
SV_BRANCH=OISF/suricata-verify#2000
#11662 with new solution, reusing
listto find buffer again at postmatchSo no longer the limitation described for flowvar in https://redmine.openinfosecfoundation.org/issues/7197