-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decode/ethertype: Event on unknown ethertype #11850
Conversation
Issue: 7129 Create a decode/engine event if unknown ethertypes are observed.
Issue: 7129 Document the unknown ethertype event.
Issue 7129 When configured with the existing "ethernet" switch, include the ether type in the output. This is most useful with anomaly records indicating unknown ethertypes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11850 +/- ##
==========================================
- Coverage 82.60% 82.57% -0.03%
==========================================
Files 912 912
Lines 249351 249361 +10
==========================================
- Hits 205965 205903 -62
- Misses 43386 43458 +72
Flags with carried forward coverage won't be shown. Click here to find out more. |
WARNING:
Pipeline 22938 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work
CI : ✅
Code : good
Commits segmentation : ok, not sure if commit "doc/threshold: Threshold keyword clarifications" belongs here
Commit messages : good
Git ID set : looks fine for me
CLA : you already contributed
Doc update : nice addition 👏 not sure we should list all the currently recognized ether types as it will grow outdated
Redmine ticket : ok, should it target 8 ?
Rustfmt : no rust
Tests : nice, thanks (why does not json log 0x integers :-p)
Dependencies added: none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline
Continued in #12495 |
Continuation of #11632
Issue: 7129
Create a decode/engine event if unknown ethertypes are observed.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7129
Describe changes:
Updates
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCH
variable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#1954
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=