util: fix -Wshorten-64-to-32 warnings #12481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12481 +/- ##
==========================================
+ Coverage 80.52% 80.54% +0.01%
==========================================
Files 923 923
Lines 259176 259204 +28
==========================================
+ Hits 208708 208778 +70
+ Misses 50468 50426 -42
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24364 |
| @@ -148,16 +148,16 @@ static int ReadFn(void *handler, char *buf, int size) | |||
| */ | |||
| static int WriteFn(void *handler, const char *buf, int size) | |||
| { | |||
| size_t count = 0; | |||
| int count = 0; | |||
| SCFmem *mem = handler; | |||
| size_t available = mem->size - mem->pos; | |||
There was a problem hiding this comment.
where is checked that his result fits an int?
There was a problem hiding this comment.
while (count < size) where size is an int from the function prototype
|
Setting as draft as I cannot set changes requested to myself |
|
Next in #12534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32warnings for some files : utilSome commits of #9840
#11952 next batch
Still to do afterwards :